Cherry-pick to release-v1.0 -- fix(circleci): CircleCI Workflow nil check for CreatedDate (#8310)#8314
Merged
Merged
Conversation
* fix(circleci): Add CircleCI workflow nil check for CreatedDate Adds a nil check during `convertWorkflows` task when CircleCI workflows API returns a weird malformed pipeline data with no created_date. Previously, the entire task fails and panics when trying to get convert a nil in ToTime util. Fixes Issue apache#8309 * Update to fix compile problems * Tweak the _tool csv to allow for the NULL value entries --------- Co-authored-by: John Ibsen <john@videa.ai>
dosubot
Bot
added
size:S
4 tasks
Contributor
Author
|
Ah looks like it maybe didn't get all the commits from the cherry-pick, didn't realize it wasn't squash and merged. I'll fix that today. 🙇 |
Contributor
|
Thanks for the PR. |
dosubot
Bot
added
size:XS
Contributor
klesh
approved these changes
Mar 7, 2025
Contributor
|
@jibsen-vh You are right. The fix looks solid to me. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #8310