feat(circleci): Cherry Pick #7820 #7986#8341
Merged
Merged
Conversation
* feat(api_collector_stateful): handle case were response has records from both before & after createdAfter of last collection * feat(circleci-plugin): incremental collection for pipelines * feat(api_collector_stateful): expose Input collector arg for StatefulFinalizableEntity to collect data based on previous collection * feat(circleci-plugin): incremental data collection for workflows * feat(circleci-plugin): incremental data collection for jobs * refactor(circleci-plugin): use common query param function * refactor(circleci-plugin): use BuildQueryParamsWithPageToken func when collecting unfinished job details
* fix(circleci-plugin): only collect pipelines from after data time range * fix(circleci-plugin): ignore 404 not found when collecting jobs or workflows
dosubot
Bot
added
the
size:L
dosubot
Bot
added
cherrypick
Contributor
|
Thanks! |
klesh
approved these changes
Mar 19, 2025
jibsen-vh
reviewed
Mar 19, 2025
Comment on lines
+62
to
+64
| if isIncremental { | ||
| clauses = append(clauses, dal.Where("created_date > ?", createdAfter)) | ||
| } |
Contributor
There was a problem hiding this comment.
@klesh this brought in a regression it looks like. Something is missing with regards to migrations - I'm still investigating, but my local deploy of this didn't do well in the first incremental attempted job.
Contributor
There was a problem hiding this comment.
@jibsen-vh I think it's because the changes from this PR were not cherrypicked: #7757
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
Re-introduces two PRs that fix various issues with the circleci plugin #7820 and #7986