Skip to content

fix: replace panic in gitextractor with error handling #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 3 commits into from
Apr 28, 2025
Merged

fix: replace panic in gitextractor with error handling #8386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1578976
replace panic in gitextractor with error handling.
galachad Apr 16, 2025
f28945b
Fix subTaskCtx.GetLogger().Error arguments
galachad Apr 17, 2025
d57864d
Merge branch 'main' into gitextract-panic
Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/plugins/gitextractor/tasks/repo_cloner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ var CloneGitRepoMeta = plugin.SubTaskMeta{
func CloneGitRepo(subTaskCtx plugin.SubTaskContext) errors.Error {
taskData, ok := subTaskCtx.GetData().(*parser.GitExtractorTaskData)
if !ok {
panic("git repo reference not found on context")
subTaskCtx.GetLogger().Error(nil, "git repo reference not found on context")
return errors.Default.New("git repo reference not found on context")
}
op := taskData.Options
storage := store.NewDatabase(subTaskCtx, op.RepoId)
Expand Down
6 changes: 4 additions & 2 deletions backend/plugins/gitextractor/tasks/repo_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,12 @@ func CollectGitDiffLines(subTaskCtx plugin.SubTaskContext) errors.Error {
func getGitRepo(subTaskCtx plugin.SubTaskContext) parser.RepoCollector {
taskData, ok := subTaskCtx.GetData().(*parser.GitExtractorTaskData)
if !ok {
panic("git repo reference not found on context")
subTaskCtx.GetLogger().Error(nil, "git repo reference not found on context")
return nil
}
if taskData.GitRepo == nil {
panic("git repo is empty, please check subtask: clone repo")
subTaskCtx.GetLogger().Error(nil, "git repo is empty, skipping Collect Commits subtask")
return nil
}
return taskData.GitRepo
}
Expand Down