Conversation
Contributor
|
@bdemers Are you going to merge it? |
Member
Author
|
🤦 Sorry, I forgot about this one, I'll rebase and retest and i'll merge it |
bdemers
force-pushed
the
update-forbiddenapis
branch
from
fe2f37c to
42371ef
Compare
This version replaces the `internalRuntimeForbidden` flag with a bundle named `jdk-non-portable` The newer version also uncoverd an issue in SingleFileLdifPartition where the RandomAccessFile uses the system file encoding. The error has been suppressed with an annotation for now. Updating the plugin will help ensure other code doesn't creep in. NOTE: The @SupressForbidden annotation is needed at compile time, but not runtime, so it has been marked provided (as there are reports of some plugins, like the maven-shade-plugin, not excluding "optional" dependencies)
bdemers
force-pushed
the
update-forbiddenapis
branch
from
42371ef to
59d8270
Compare
bdemers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version replaces the
internalRuntimeForbiddenflag with a bundle namedjdk-non-portableThe newer version also uncoverd an issue in SingleFileLdifPartition where the RandomAccessFile uses the system file encoding. The error has been suppressed with an annotation for now. Updating the plugin will help ensure other code doesn't creep in.NOTE: The @SupressForbidden annotation is needed at compile time, but not runtime, so it has been marked provided (as there are reports of some plugins, like the maven-shade-plugin, not excluding "optional" dependencies)