Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

DL-206: Delete the log should also delete the underline ledgers#152

Closed
yzang wants to merge 1 commit intoapache:masterfrom
yzang:yzang/DL-206
Closed

DL-206: Delete the log should also delete the underline ledgers#152
yzang wants to merge 1 commit intoapache:masterfrom
yzang:yzang/DL-206

Conversation

@yzang
Copy link
Copy Markdown

@yzang yzang commented Aug 23, 2017

Problem:
We're not deleting the ledgers when we delete the whole log stream using dlm.delete() API. This would cause a lot of garbage/orphan ledgers in Bookkeeper.

The fix is to delete the ledger when we delete the log stream. Also added a test to validate.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    <Issue-# or DL-#>: Description of pull request
    e.g. Issue-123: Description ...
    e.g. DL-1234: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install findbugs:check.
  • Replace '#' with in <Issue-# or DL-#> in the title with the actual Issue/JIRA number.

@sijie
Copy link
Copy Markdown
Member

sijie commented Aug 24, 2017

@yzang awesome! this change looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants