Skip to content

Translate the registry_spi.md#399

Merged
davidzollo merged 9 commits intoapache:masterfrom
QuakeWang:translation
Jul 7, 2021
Merged

Translate the registry_spi.md#399
davidzollo merged 9 commits intoapache:masterfrom
QuakeWang:translation

Conversation

@QuakeWang
Copy link
Contributor

According to this document, then translated it.

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 8164dd9 into apache:master Jul 7, 2021
davidzollo added a commit that referenced this pull request Jul 7, 2021
davidzollo added a commit that referenced this pull request Jul 7, 2021

#### How to use?

First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` installation plugin to generate the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meaning of the first sentence may be ambiguous. "First, you need to execute the mvn -U install package -Prelease -Dmaven.test.skip=true to install the plugin for generating the plugin JAR of the registry." should be better.
BTY, a full stop is missed in the second sentence:).

@@ -0,0 +1,27 @@
### Dolphinscheduler Registry SPI main design

#### How to use?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, "how to use?" is not a correct structure. Here you can directly use "The usage instruction" or any other similar phrases, or the corrected version "How to use it?"(phrase version)/"How do you use it?"(sentence version).


2:registry connect timeout

You can increase the relevant timeout parameters.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“increase“ should be “add”


1: not found registry plugin

Please check that `mvn -U install package -Prelease -Dmaven.test.skip=true` is executed, and that the directory configured in registry.plugin.dir in the configuration file contains the relevant plugins.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may miss the "if" in first half of sentence "Please check if ...". And for the second half, It demonstrates better as "Besides, Please check if the directory ..." while taking this whole sentence into two seperate parts.

| registry.plugin.binding | registry | Dolphinscheduler plugin category |
| registry.servers | 127.0.0.1:2181 | ZK connection address |

For specific configuration information, please refer to the parameter information that provided by the specific plugin, for example zk: org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperConfiguration.java All configuration information should be prefixed with +registry. For example, base.sleep.time.ms should be configured in the registry like this: registry.base.sleep.time.ms=100.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a little bit about this sentence. The meaning of this version would be clearer and you can take it as a reference.
"For the specific configuration information, please refer to the parameter information that provided by the specific plugin. Taking zk as an example, all the parameters of this configuration information about zk are in the class org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperConfiguration.java. If a parameter is needed to be changed to a specific value instead of the default, it can be configured directly in the registry. However, the prefix should be added to indicate this is a parameter of the registry. For example, "base.sleep.time.ms" should be configured in the registry as: "registry.base.sleep.time.ms=100"."

@QuakeWang
Copy link
Contributor Author

@ptyp Thank you for the review, I have completed the changes. As this pr has been revert, we can discuss it in this #402 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants