Merged
Conversation
zhongjiajie
reviewed
Oct 20, 2021
| The user needs to define ${setValue(key=value)} in the output when defining the shell script. | ||
|
|
||
| Remove $setValue() when processing parameters, split by "=", with the 0th being the key and the 1st being the value. | ||
| Remove ${setValue()} when processing parameters, split by "=", with the 0th being the key and the 1st being the value. |
Member
There was a problem hiding this comment.
@caishunfeng I find out we still have content $setValue( in https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/guide/parameter/context.html and somewhere else. should we also change those code too?
Contributor
Author
There was a problem hiding this comment.
Yes, it should be change too.
davidzollo
pushed a commit
to davidzollo/dolphinscheduler-website
that referenced
this pull request
Dec 17, 2021
* fix global params set value * fix setValue Co-authored-by: caishunfeng <534328519@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.