add datasource spi design doc (#6071)#500
Merged
CalvinKirs merged 4 commits intoapache:masterfrom Dec 13, 2021
Merged
Conversation
Contributor
Narcasserun
commented
Nov 2, 2021
Narcasserun
commented
- add datasource spi design doc
Member
|
@Narcasserun Does this PR ready to go now? |
CalvinKirs
reviewed
Nov 30, 2021
Comment on lines
+20
to
+29
| datasource.plugin.dir =./dolphinscheduler-dist/target/dolphinscheduler-dist-${VERSION}/lib/plugin/datasource | ||
| ``` | ||
|
|
||
| The following configurations can be used for local development debugging, for example: | ||
|
|
||
| ``` | ||
| maven.local.repository=/Users/localRepository | ||
| datasource.plugin.binding=./dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-sqlserver/pom.xml | ||
| ``` | ||
|
|
Member
There was a problem hiding this comment.
I look you change plugin load method,This document is no longer applicable
Member
|
@Narcasserun Is this PR good to go or not? |
Contributor
Author
go go go |
CalvinKirs
approved these changes
Dec 13, 2021
davidzollo
pushed a commit
to davidzollo/dolphinscheduler-website
that referenced
this pull request
Dec 17, 2021
* add datasource spi design doc * add datasource spi design doc * add datasource spi design doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.