[BUG] [Plugin] Conditions Task branch flow failed

[Dannila]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

Condition is a condition node that decides which downstream task should run based on the condition of the upstream task. When the upstream task runs successfully, run the success branch. When the upstream task fails to run, run the failure branch. But now no matter whether the upstream task runs successfully or fails, only the tasks of the successful branch will be run.

What you expected to happen

The Condition task should decide which downstream task should run based on the conditions of the upstream task.

How to reproduce

Create a Condition task, determine the successful or failed branch task and run it。

When the upstream task runs successfully, Conditions select the successful branch task and run it.

But when the upstream task fails to run, Conditions still select the successful branch task and run it.

Anything else

No response

Version

dev

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

• In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
• If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

[SbloodyS]

I will fix it.

[huangchenguang123]

I will fix it.

Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong.

[SbloodyS]

I will fix it.

Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong.

Yes. In this PR, I change the detection logic to use previousNodes to check condition instead of use dependency result.

However, I don't think the success or failure of task nodes should be related to user-defined parameters.

[huangchenguang123]

I will fix it.

Conditions should use previousNodes result, and now only use dependency result? I find add Custom Parameters can make it trigger fail Node....May be #10077 should use previousNodes and/or Custom Parameters? This is my doubt, don't mind if I'm wrong.

Yes. In this PR, I change the detection logic to use previousNodes to check condition instead of use dependency result.

However, I don't think the success or failure of task nodes should be related to user-defined parameters.

The Condition's Custom Parameters is different from other task, it's has and/or relation with pre node in ui(it's also only has success and failure), and when i run the task, these Custom Parameters will be used in dependencyList, this is why i think they should be calculate together.

[SbloodyS]

@huangchenguang123 This is the dependent task node. Not condition task node.

[huangchenguang123]

@huangchenguang123 This is the dependent task node. Not condition task node.

This is condition task node. May be you can try?

[SbloodyS]

@huangchenguang123 This is the dependent task node. Not condition task node.

This is condition task node. May be you can try?

I take a deep look into UI. There are indeed some misleading description of UI. I'll fix it too. Thanks.