Skip to content

[Improvement][Dao] reduce code specification warnings #11705

@DarkAssassinator

Description

@DarkAssassinator

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

when add some fields in some entity, found that there are many code warninng in org.apache.dolphinscheduler.dao.entity.*, becauase these long code can replaceabled by Objects.equals() expression
image

And i think there are some issue, why it will return false when Objects.equals(environmentCode, command.environmentCode)

What you expected to happen

clean code

How to reproduce

just review the source code, such as org.apache.dolphinscheduler.dao.entity.Command

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions