Skip to content

[Improvement][DataSourcePlugin]tiny optimize of datasource plugin module #14541

@genuinner

Description

@genuinner

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

when I study adding datasource plugin, i find the datasource-special constants like COM_CLICKHOUSE_JDBC_DRIVER = "com.clickhouse.jdbc.ClickHouseDriver" only used in ClickHouseDataSourceProcessor, so i move all related constant to the special DataSourceProcessor, it does not make too much sense, I just think it is a better format and pattern, after that, I can easily setDefaultValidationQuery to fit various datasource, which has problem using the original code.
So you can evaluate if this change is needed.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions