[Bug][SQL] Only 10,000 data in the attachment

[syb853553110]

**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
Describe the bug
（1）Only 10,000 data in the attachment。
In fact, there are 170,000 records in mysql。
（2）In addition, when the subject of the email is too long, the suffix of the attachment is incorrect.

To Reproduce
Steps to reproduce the behavior, for example:

Expected behavior
（1）The number of data in the attachment is the same as in mysql
（2）The file name and suffix in the attachment are correct. It is recommended that the name of the attachment can be customized

Which version of Dolphin Scheduler:
-[1.3.6 Release]

[github-actions]

Hi:

• Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
• In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
• If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.

[ruanwenjun]

@syb853553110 Only 10000 rows of results will be sent 😄

dolphinscheduler/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java

Lines 89 to 93 in f8ecb53

	/**
	* default query sql limit
	*/
	private static final int LIMIT = 10000;

[syb853553110]

@syb853553110 Only 10000 rows of results will be sent 😄

dolphinscheduler/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java

Lines 89 to 93 in f8ecb53

	/**
	* default query sql limit
	*/
	private static final int LIMIT = 10000;

有参数可以修改嘛

[ruanwenjun]

@syb853553110 It's hard code, you can submit a pr to improve.

[syb853553110]

@syb853553110 It's hard code, you can submit a pr to improve.
I looked at the source code and found the attachment name problem。

我看了下源码，找到了附件名称不对的问题，主要是这行代码的问题
org.apache.dolphinscheduler.alert.utils.MailUtils
part2.setFileName(MimeUtility.encodeText(title + Constants.EXCEL_SUFFIX_XLS,Constants.UTF_8,"B"));
改成
part2.setFileName(title + Constants.EXCEL_SUFFIX_XLS);
附件名称就不会出问题

[syb853553110]

@syb853553110 It's hard code, you can submit a pr to improve.

In addition, I think the way the attachment is generated can be optimized. The current plan is to put all into a JSONArray, and then generate files. I think it is possible to write 10,000 files at a time, which can solve the problem of excessive memory usage caused by putting all the files in the memory at one time. Is the limit of 10,000 also considered the problem of excessive memory usage when the amount of data is too large?

[ruanwenjun]

@syb853553110 It's hard code, you can submit a pr to improve.
I looked at the source code and found the attachment name problem。

我看了下源码，找到了附件名称不对的问题，主要是这行代码的问题
org.apache.dolphinscheduler.alert.utils.MailUtils
part2.setFileName(MimeUtility.encodeText(title + Constants.EXCEL_SUFFIX_XLS,Constants.UTF_8,"B"));
改成
part2.setFileName(title + Constants.EXCEL_SUFFIX_XLS);
附件名称就不会出问题

Is the title in the database displayed correctly?

Query return number need to have a restriction, but I think it should be configurable, you can submit a pr to improve.

[syb853553110]

@syb853553110 It's hard code, you can submit a pr to improve.
I looked at the source code and found the attachment name problem。

我看了下源码，找到了附件名称不对的问题，主要是这行代码的问题
org.apache.dolphinscheduler.alert.utils.MailUtils
part2.setFileName(MimeUtility.encodeText(title + Constants.EXCEL_SUFFIX_XLS,Constants.UTF_8,"B"));
改成
part2.setFileName(title + Constants.EXCEL_SUFFIX_XLS);
附件名称就不会出问题

Is the title in the database displayed correctly?
Yes， is correct。 Only the name of attachment is incorrect when the titile is too long。
For example, "2021-05月某某公司通话数据明细"

Query return number need to have a restriction, but I think it should be configurable, you can submit a pr to improve.

[caishunfeng]

This issue will be closed because no update for a long time. You can reopen it if need.