[Bug] [API]Update tenant failed in API

[roylion]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

    /**
     * if the tenant code is modified, the original resource needs to be copied to the new tenant.
     */
    if (!tenant.getTenantCode().equals(tenantCode)) {
        if (checkTenantExists(tenantCode)) { **********************此处判断条件有误**********************
            // if hdfs startup
            省略。。。
        } else {
            putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
            return result;
        }
    }

What you expected to happen

    /**
     * if the tenant code is modified, the original resource needs to be copied to the new tenant.
     */
    if (!tenant.getTenantCode().equals(tenantCode)) {
        if (!checkTenantExists(tenantCode)) { **********************此处判断条件改为不存在时复制资源**********************
            // if hdfs startup
            省略。。。
        } else {
            putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
            return result;
        }
    }

How to reproduce

修改一个已存在的租户名称，且新的租户名称没有与其他租户名称重复，提交时会提示 “操作系统租户已存在”

版本号：2.0.1-release

Anything else

No response

Version

dev

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

    /**
     * if the tenant code is modified, the original resource needs to be copied to the new tenant.
     */
    if (!tenant.getTenantCode().equals(tenantCode)) {
        if (checkTenantExists(tenantCode)) { **********************此处判断条件有误**********************
            // if hdfs startup
            省略。。。
        } else {
            putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
            return result;
        }
    }

What you expected to happen

    /**
     * if the tenant code is modified, the original resource needs to be copied to the new tenant.
     */
    if (!tenant.getTenantCode().equals(tenantCode)) {
        if (!checkTenantExists(tenantCode)) { **********************此处判断条件改为不存在时复制资源**********************
            // if hdfs startup
            省略。。。
        } else {
            putMsg(result, Status.OS_TENANT_CODE_HAS_ALREADY_EXISTS);
            return result;
        }
    }

How to reproduce

修改一个已存在的租户名称，且新的租户名称没有与其他租户名称重复，提交时会提示 “操作系统租户已存在”

版本号：2.0.1-release

Anything else

No response

Version

dev

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Hi:

• Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
• In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
• If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.

[calvinjiang]

I will check this issue.

[calvinjiang]

Could you shed some more light on it? Give more details about this issue.

Seems like you can't modify the tenant's name:

[lenboo]

Could you shed some more light on it? Give more details about this issue.

Seems like you can't modify the tenant's name:

Maybe we should remove the update interface in api.