[Bug] [dolphinscheduler-api] After the workflow is deleted, the task definition under the workflow is not deleted

[janeHe13]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

What you expected to happen

.

How to reproduce

.

Anything else

No response

Version

dev

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Hi:

• Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
• In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
• If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.

[SbloodyS]

This logic might be missing during splitting task from workflow. Related issue: #7767

I was wondering if the process instance and its task instance should be deleted while deleting the process definition. I think the process instance and its task instance is meaningless when its workflow doesn't exist. WDYT? @caishunfeng @zhongjiajie

[caishunfeng]

I was wondering if the process instance and its task instance should be deleted while deleting the process definition. I think the process instance and its task instance is meaningless when its workflow doesn't exist. WDYT? @caishunfeng @zhongjiajie

Agree with you, when delete process definition, it should alse delete the task definition, process_task_relation, process instances, task instances, schedule.

[SbloodyS]

I was wondering if the process instance and its task instance should be deleted while deleting the process definition. I think the process instance and its task instance is meaningless when its workflow doesn't exist. WDYT? @caishunfeng @zhongjiajie

Agree with you, when delete process definition, it should alse delete the task definition, process_task_relation, process instances, task instances, schedule.

I'll submit a pr to fix this issue.

[zhongjiajie]

Agree with you, when delete process definition, it should alse delete the task definition, process_task_relation, process instances, task instances, schedule.

One more thing, I have vague memories that we have task definition related to one or muliple process definition, in that case we should not delete those task related to other process definition, am I right

[SbloodyS]

Agree with you, when delete process definition, it should alse delete the task definition, process_task_relation, process instances, task instances, schedule.

One more thing, I have vague memories that we have task definition related to one or muliple process definition, in that case we should not delete those task related to other process definition, am I right

In this case, If a process definition or its task definition dependented/subprocessed by other process or task. Should it able to delete or not?

[caishunfeng]

In this case, If a process definition or its task definition dependented/subprocessed by other process or task. Should it able to delete or not?

I think if a process definition was offline, although it was dependented by other process, like dependent task or switch task, it will also take no effect.It is up to user, but it's better to give a tips, such as double confirm before delete.

[SbloodyS]

In this case, If a process definition or its task definition dependented/subprocessed by other process or task. Should it able to delete or not?

I think if a process definition was offline, although it was dependented by other process, like dependent task or switch task, it will also take no effect.It is up to user, but it's better to give a tips, such as double confirm before delete.

Do you mean that promt the user which tasks depend on the current task when deleting process definition?

[caishunfeng]

In this case, If a process definition or its task definition dependented/subprocessed by other process or task. Should it able to delete or not?

I think if a process definition was offline, although it was dependented by other process, like dependent task or switch task, it will also take no effect.It is up to user, but it's better to give a tips, such as double confirm before delete.

Do you mean that promt the user which tasks depend on the current task when deleting process definition?

yes

[SbloodyS]

In this case, If a process definition or its task definition dependented/subprocessed by other process or task. Should it able to delete or not?

I think if a process definition was offline, although it was dependented by other process, like dependent task or switch task, it will also take no effect.It is up to user, but it's better to give a tips, such as double confirm before delete.

Do you mean that promt the user which tasks depend on the current task when deleting process definition?

yes

This require the front-end modify the deletion logic. First, request the dependency check interface. If no dependency is returned, then request to delete the existing interface. If not, promt user which tasks depend on the current task and let user to chose action.