Skip to content

[fix][doc]: fix conditions.md cannot be previewed by markdown#10127

Closed
huangchenguang123 wants to merge 1 commit intoapache:devfrom
huangchenguang123:hotfix/fix_doc
Closed

[fix][doc]: fix conditions.md cannot be previewed by markdown#10127
huangchenguang123 wants to merge 1 commit intoapache:devfrom
huangchenguang123:hotfix/fix_doc

Conversation

@huangchenguang123
Copy link
Contributor

fix #10126

@zhongjiajie
Copy link
Member

@huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website

@zhongjiajie
Copy link
Member

If you have time and interesting in issue #9426, and feel free to take it

@huangchenguang123
Copy link
Contributor Author

@huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website

Think.You mean I have to modify the script on the website to be compatible with the display of the pictures on dolphinscheduler.apache.org?

@zhongjiajie
Copy link
Member

zhongjiajie commented May 20, 2022

@huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website

Think.You mean I have to modify the script on the website to be compatible with the display of the pictures on dolphinscheduler.apache.org?

yeah, we have some example in apache/seatunnel, it will convert img path and make them work bot github markdown and website. https://github.com/apache/incubator-seatunnel-website/blob/104e0b815952d41ba03817c515d9613bde9c84cf/tools/build-docs.sh#L121-L137

@huangchenguang123
Copy link
Contributor Author

close by batch fix

@zhongjiajie
Copy link
Member

close by batch fix

@huangchenguang123 Thanks for your contribution to prepare_docs.sh in repo apache/dolphinscheduler-website ❤️

@huangchenguang123 huangchenguang123 deleted the hotfix/fix_doc branch June 21, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [doc] conditions.md'image cannot be previewed by markdown

3 participants