Skip to content

[Cherry-Pick][Fix][UI]Change the HTTP or HTTPS regular expression (#10166)#10176

Merged
songjianet merged 1 commit intoapache:3.0.0-beta-preparefrom
labbomb:300cp
May 21, 2022
Merged

[Cherry-Pick][Fix][UI]Change the HTTP or HTTPS regular expression (#10166)#10176
songjianet merged 1 commit intoapache:3.0.0-beta-preparefrom
labbomb:300cp

Conversation

@labbomb
Copy link
Member

@labbomb labbomb commented May 20, 2022

Purpose of the pull request

refer to [#10166 ]

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (3.0.0-beta-prepare@0279391). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             3.0.0-beta-prepare   #10176   +/-   ##
=====================================================
  Coverage                      ?   40.63%           
  Complexity                    ?     4576           
=====================================================
  Files                         ?      834           
  Lines                         ?    33863           
  Branches                      ?     3755           
=====================================================
  Hits                          ?    13761           
  Misses                        ?    18782           
  Partials                      ?     1320           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0279391...ceb0f05. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

37.0% 37.0% Coverage
0.6% 0.6% Duplication

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet added bug Something isn't working UI ui and front end related labels May 21, 2022
@songjianet songjianet added this to the 3.0.0-beta-1 milestone May 21, 2022
@songjianet songjianet merged commit 4cb307e into apache:3.0.0-beta-prepare May 21, 2022
@labbomb labbomb deleted the 300cp branch May 23, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants