[fix] Fix the SERIAL_DISCARD execution_type not working#10258
Merged
caishunfeng merged 2 commits intoapache:devfrom May 30, 2022
Merged
[fix] Fix the SERIAL_DISCARD execution_type not working#10258caishunfeng merged 2 commits intoapache:devfrom
caishunfeng merged 2 commits intoapache:devfrom
Conversation
cadl
changed the title
SbloodyS
added
bug
Contributor
Author
|
Hi @SbloodyS Already changed unit test. Please re-run ci workflows 🙏 |
Member
I rerun it. |
Codecov Report
@@ Coverage Diff @@
## dev #10258 +/- ##
============================================
- Coverage 41.25% 41.24% -0.02%
+ Complexity 4760 4758 -2
============================================
Files 854 854
Lines 34579 34582 +3
Branches 3821 3821
============================================
- Hits 14265 14262 -3
- Misses 18944 18948 +4
- Partials 1370 1372 +2
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
@caishunfeng Do you have time take a look? |
caishunfeng
approved these changes
May 30, 2022
Contributor
caishunfeng
left a comment
caishunfeng
left a comment
There was a problem hiding this comment.
LGTM, @cadl thanks for your contribution.
ITBOX-ITBOY
pushed a commit
to ITBOX-ITBOY/dolphinscheduler
that referenced
this pull request
Jul 8, 2022
* fix always stop process_instance when execution_type is SERIAL_DISCARD * test: no running_process, submit it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
I found the
SERIAL_DISCARDexecution_type always stops the process instance, even if there were no running process instances.After diving into the code, It seems like some logic error. Before the fix, the ProcessServiceImpl will stop the current process_instance, if running_instances is empty.
Now make some fixes, if running_instances is not empty, mark the current process_instance as stop (discard it). if running_instances is empty, submit the current process_instance.
Brief change log
fix SERIAL_DISCARD not working
Verify this pull request