Skip to content

[Fix-10367] Permission check related key adjustment.#10368

Merged
caishunfeng merged 11 commits intoapache:devfrom
WangJPLeo:jp-audit-log
Jun 9, 2022
Merged

[Fix-10367] Permission check related key adjustment.#10368
caishunfeng merged 11 commits intoapache:devfrom
WangJPLeo:jp-audit-log

Conversation

@WangJPLeo
Copy link
Contributor

Purpose of the pull request

Permission check related key adjustment.

Brief change log

close #10367

Verify this pull request

Manually verified the change by testing locally.

@WangJPLeo WangJPLeo requested a review from caishunfeng as a code owner June 6, 2022 12:53
@songjianet songjianet added bug Something isn't working backend labels Jun 6, 2022
@songjianet songjianet added this to the 3.0.0-beta-2 milestone Jun 6, 2022
@caishunfeng
Copy link
Contributor

@WangJPLeo Please solve the UT error.

@WangJPLeo
Copy link
Contributor Author

@WangJPLeo Please solve the UT error.

ok

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #10368 (7ac63f7) into dev (36bba3f) will decrease coverage by 0.06%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##                dev   #10368      +/-   ##
============================================
- Coverage     40.57%   40.51%   -0.07%     
- Complexity     4741     4758      +17     
============================================
  Files           869      877       +8     
  Lines         35286    35612     +326     
  Branches       3935     3945      +10     
============================================
+ Hits          14318    14427     +109     
- Misses        19538    19749     +211     
- Partials       1430     1436       +6     
Impacted Files Coverage Δ
...r/api/constants/ApiFuncIdentificationConstant.java 88.23% <ø> (ø)
...i/service/impl/AlertPluginInstanceServiceImpl.java 58.49% <0.00%> (ø)
...heduler/api/service/impl/ResourcesServiceImpl.java 48.47% <57.14%> (+0.06%) ⬆️
...heduler/api/service/impl/TaskGroupServiceImpl.java 65.38% <80.00%> (-0.77%) ⬇️
...uler/api/service/impl/DataAnalysisServiceImpl.java 79.13% <90.90%> (+2.04%) ⬆️
...scheduler/api/service/impl/UdfFuncServiceImpl.java 71.63% <100.00%> (ø)
...ache/impl/ProcessInstanceExecCacheManagerImpl.java 84.61% <0.00%> (-15.39%) ⬇️
...r/server/master/registry/MasterRegistryClient.java 43.90% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bba3f...7ac63f7. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

80.3% 80.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 9782fe4 into apache:dev Jun 9, 2022
@devosend devosend modified the milestones: 3.0.0-beta-2, 3.1.0-alpha Jun 16, 2022
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
* Permission check related key adjustment.

* resource create or upload fix.

* Analysis Permission fix.

* Ut coverage add.

* rerun

* source permission fix.

* ut coverage is achieved

* Reference permission package path modification

* k8s path bug fix.

* k8s path bug fix.

* Corrected controller method name and rerun.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Permission] Permission check related keys need to be adjusted

5 participants