Conversation
|
That's a cool~ |
Codecov Report
@@ Coverage Diff @@
## dev #10397 +/- ##
============================================
- Coverage 39.46% 39.29% -0.17%
Complexity 4247 4247
============================================
Files 1052 1061 +9
Lines 39860 40050 +190
Branches 4582 4600 +18
============================================
+ Hits 15731 15739 +8
- Misses 22349 22530 +181
- Partials 1780 1781 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
zhongjiajie
left a comment
There was a problem hiding this comment.
backend and docs LGTM, @devosend please task a look at the frontend code
docs/docs/zh/guide/task/blocking.md
Outdated
|
|
||
| 如果你有配置告警相关组件(例如email),那么将会收到一封告警邮件 | ||
|
|
||
| ## No newline at end of file |
There was a problem hiding this comment.
It seems that is unnecessary adding
docs/docs/en/guide/task/blocking.md
Outdated
|
|
||
| This sample demonstrates the operation of the Condition task by using the [Shell](shell.md) task and [Python](python.md) task. | ||
|
|
||
| ### 1. Create Workflow |
There was a problem hiding this comment.
should avoid using number in title, the leading number of # represent the level
| ### 1. Create Workflow | |
| ### Create Workflow |
|
I am very very sorry for updating this PR so late because of the busy work and training. I see projects iterating rapidly and the back-end code for the blocking node is still being maintained. I sincerely appreciated. |
@mgsky1 No worries, we are glad that you could follow up with this PR. The CI failed because of formatting errors, could u plz run |
ok,I will run this command later today~ |
|
There are still some errors occured in the Actions. I will fixed them later, maybe in this weekend |
87613d6 to
3371e86
Compare
3371e86 to
5baba60
Compare
|
SonarCloud Quality Gate failed. |
|
I fixed some error in code so that the Actions could be executed. I also clean the commits. The commit logs before are so terrible.@EricGao888 |
|
Hi @mgsky1 It's great to follow up the blocking task feature 👍 |
|
@devosend @Amy0104 @songjianet Do you have time to review this pr? |
|
Please resolve the conflict. @mgsky1 |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |








Purpose of the pull request
This PR adds blocking task UI and documentation. The blocking task node backed code has been merged in PR #6272.
Brief change log
Screen Shots
Verify this pull request
Test cases:
They all work fine.
Discuss
此PR的目的
为了完善阻断类任务的开发,后端代码已经在PR#6272中被合并
变更日志
截图
测试
主要测试了以下几种情况
它们都能正常工作
讨论
IJsonItem数组,不知道这种场景下,要用IJsonItem的什么字段给开关赋值。从现有的代码参考看,如果是在节点配置面板中使用了switch开关,那么开启开关后,会弹出更详细的设置信息;另外一处是在工作流空跑时出现的,那个场景是直接用HTML标签搞定的。