Skip to content

[fix][Python] Support same task name in project defferent process definition#10428

Merged
zhongjiajie merged 13 commits intoapache:devfrom
hiSandog:query-task
Jun 14, 2022
Merged

[fix][Python] Support same task name in project defferent process definition#10428
zhongjiajie merged 13 commits intoapache:devfrom
hiSandog:query-task

Conversation

@hiSandog
Copy link
Copy Markdown
Contributor

@hiSandog hiSandog commented Jun 13, 2022 •
edited by zhongjiajie
Loading

Now I can't set tasks with the same name in different process of the same project through python-gate.
It forces me to prefix the task name with the process name.It's very inconvenient.
I think python-gate should support setting the same task name in the same project for different process.

close: #10431

chenjiaming added 3 commits June 13, 2022 16:07
@SbloodyS
Copy link
Copy Markdown
Member

SbloodyS commented Jun 13, 2022

Hi @hiSandog , please associate issue.

@SbloodyS SbloodyS added bug Something isn't working backend Pyscheduler labels Jun 13, 2022
@hiSandog hiSandog changed the title [Improvement][Python] Python-gate support setting the same task name in the same project for different process. [Bug-10431][Python] Python-gate support setting the same task name in the same project for different process. Jun 13, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

zhongjiajie commented Jun 14, 2022

Now I can't set tasks with the same name in different process of the same project through python-gate. It forces me to prefix the task name with the process name.It's very inconvenient. I think python-gate should support setting the same task name in the same project for different process.

close: #10431

Hi @hiSandog , thanks to find and fix this. Will take a look right now ❤️

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #10428 (707ae1d) into dev (3258438) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev   #10428      +/-   ##
============================================
+ Coverage     40.56%   40.58%   +0.02%     
- Complexity     4766     4774       +8     
============================================
  Files           877      878       +1     
  Lines         35621    35746     +125     
  Branches       3945     3970      +25     
============================================
+ Hits          14449    14507      +58     
- Misses        19737    19789      +52     
- Partials       1435     1450      +15
Impacted Files Coverage Δ
...che/dolphinscheduler/api/python/PythonGateway.java 17.00% <42.85%> (+7.76%) ⬆️
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <100.00%> (ø)
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) ⬇️
...pache/dolphinscheduler/service/corn/CronUtils.java 64.77% <0.00%> (-5.60%) ⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java 40.10% <0.00%> (-2.59%) ⬇️
.../server/master/runner/WorkflowExecuteRunnable.java 7.75% <0.00%> (-0.07%) ⬇️
.../server/master/runner/StateWheelExecuteThread.java 0.47% <0.00%> (-0.01%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
.../org/apache/dolphinscheduler/common/Constants.java 80.95% <0.00%> (ø)
...inscheduler/server/master/config/MasterConfig.java 76.74% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3258438...707ae1d. Read the comment docs.

zhongjiajie
zhongjiajie approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

14.8% 14.8% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie merged commit b86dc53 into apache:dev Jun 14, 2022
@zhongjiajie zhongjiajie added this to the 3.0.0-beta-2 milestone Jun 14, 2022
@zhongjiajie zhongjiajie changed the title [Bug-10431][Python] Python-gate support setting the same task name in the same project for different process. [fix][Python] Support same task name in project defferent process definition Jun 14, 2022
devosend pushed a commit that referenced this pull request Jun 18, 2022
@hiSandog @devosend
[fix][Python] Support same task name in project defferent process def…
476f239 
…inition (#10428)

close: #10431
(cherry picked from commit b86dc53)
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jun 23, 2022
@hiSandog @hstdream
[fix][Python] Support same task name in project defferent process def…
4c6c960 
…inition (apache#10428)

close: apache#10431
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
@hiSandog
[fix][Python] Support same task name in project defferent process def…
7c8d2f0 
…inition (apache#10428)

close: apache#10431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@hiSandog hiSandog

Labels

backend bug Something isn't working Pyscheduler

Projects

None yet

Milestone

3.0.0-beta-2

Development

Successfully merging this pull request may close these issues.

[Bug] [Python] Python-gate can't support setting the same task name in the same project for different process

4 participants

@hiSandog @SbloodyS @zhongjiajie @codecov-commenter