Open checkstyle, change checkstyle severity from info to warning#10492
Merged
ruanwenjun merged 4 commits intoapache:devfrom Jun 17, 2022
Merged
Open checkstyle, change checkstyle severity from info to warning#10492ruanwenjun merged 4 commits intoapache:devfrom
ruanwenjun merged 4 commits intoapache:devfrom
Conversation
kezhenxu94
previously approved these changes
Jun 17, 2022
SbloodyS
reviewed
Jun 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
hstdream
pushed a commit
to hstdream/dolphinscheduler
that referenced
this pull request
Jun 23, 2022
…che#10492) * Open checkstyle, change checkstyle severity from info to warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Right now, the checkstyle is unused, since we set severity level to info, this means when someone break the checkstyle rule, the will be a info log, the CI/checkstyle task will still pass.
todo: We need to config a checkstyle task on ci.
Brief change log
Change checkstyle severity to warning.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: