Skip to content

[Fix-10539] [Bug] [UI] Copy task a to B, change the user-defined para…#10611

Merged
Amy0104 merged 6 commits intoapache:devfrom
pinkhello:fixed-10539-copy-task-params
Jun 27, 2022
Merged

[Fix-10539] [Bug] [UI] Copy task a to B, change the user-defined para…#10611
Amy0104 merged 6 commits intoapache:devfrom
pinkhello:fixed-10539-copy-task-params

Conversation

@pinkhello
Copy link
Contributor

@pinkhello pinkhello commented Jun 25, 2022

Purpose of the pull request

this pr Fixed #10539 .

Brief change log

Add cloneDeep for use-task-edit#copyTask

Verify this pull request

This pull request is code cleanup without any test coverage.

issue steps to reproduce

  • first step
    w1T7OY5iHV
    Gbbkb3D2wh

  • copy task node
    sExai9wP4D
    4894uxJpVD

  • remove params
    YWyE7Vrlog

  • check params from task 1
    xwwfSKoLRW

fixed check

  • first
    af3iUVCvPe
    HkYC9ewifb

  • remove params
    iLDBFXtj0N

  • check task1
    77ZP4rDJ4t

…meters of Task B, and change the parameters of task a
@pinkhello pinkhello changed the title fixed 10539: [Bug] [ui]Copy task a to B, change the user-defined para… [Fixed] [Bug] [ui] Copy task a to B, change the user-defined para… Jun 25, 2022
@pinkhello pinkhello changed the title [Fixed] [Bug] [ui] Copy task a to B, change the user-defined para… [Fixed] [Bug] [UI] Copy task a to B, change the user-defined para… Jun 25, 2022
…meters of Task B, and change the parameters of task a
@pinkhello pinkhello changed the title [Fixed] [Bug] [UI] Copy task a to B, change the user-defined para… [Fix-10539] [Bug] [UI] Copy task a to B, change the user-defined para… Jun 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2022

Codecov Report

Merging #10611 (ccaba64) into dev (16144a8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10611      +/-   ##
============================================
- Coverage     40.93%   40.93%   -0.01%     
+ Complexity     4875     4874       -1     
============================================
  Files           895      895              
  Lines         36212    36212              
  Branches       3987     3987              
============================================
- Hits          14824    14822       -2     
- Misses        19922    19927       +5     
+ Partials       1466     1463       -3     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/remote/utils/Host.java 43.47% <0.00%> (-2.18%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16144a8...ccaba64. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pinkhello
Copy link
Contributor Author

@songjianet @Amy0104 CR, please

@SbloodyS SbloodyS added bug Something isn't working UI ui and front end related labels Jun 27, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 27, 2022
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit b8de9ee into apache:dev Jun 27, 2022
@pinkhello pinkhello mentioned this pull request Jul 14, 2022
caishunfeng pushed a commit that referenced this pull request Jul 20, 2022
#10611)

* fixed 10539: [Bug] [ui]Copy task a to B, change the user-defined parameters of Task B, and change the parameters of task a

* fixed 10539: [Bug] [ui]Copy task a to B, change the user-defined parameters of Task B, and change the parameters of task a

* feat: reactor code

* feat: remove console.info

* fixed: reactor deepclone

* feat: code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy task a to B, change the user-defined parameters of Task B, and change the parameters of task a

4 participants