Skip to content

[fix-10596] Workflow relationship cannot be displayed normally#10625

Merged
SbloodyS merged 1 commit intoapache:devfrom
liudi1184:dev
Jun 27, 2022
Merged

[fix-10596] Workflow relationship cannot be displayed normally#10625
SbloodyS merged 1 commit intoapache:devfrom
liudi1184:dev

Conversation

@liudi1184
Copy link
Contributor

@liudi1184 liudi1184 commented Jun 27, 2022

Workflow relationship cannot be displayed normally

Closes #10596

[fix-10596] Workflow relationship cannot be displayed normally
369ba9c 
Workflow relationship cannot be displayed normally

Closes apache#10596
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor backend labels Jun 27, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #10625 (369ba9c) into dev (719a9d4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #10625      +/-   ##
============================================
- Coverage     40.94%   40.92%   -0.02%     
+ Complexity     4876     4872       -4     
============================================
  Files           895      895              
  Lines         36212    36213       +1     
  Branches       3987     3988       +1     
============================================
- Hits          14826    14820       -6     
- Misses        19921    19928       +7     
  Partials       1465     1465
Impacted Files Coverage Δ
...r/api/service/impl/WorkFlowLineageServiceImpl.java 33.01% <0.00%> (-0.32%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 43.47% <0.00%> (-2.18%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719a9d4...369ba9c. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

SbloodyS
SbloodyS approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felix-thinkingdata
felix-thinkingdata approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@felix-thinkingdata felix-thinkingdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felix-thinkingdata
felix-thinkingdata approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@felix-thinkingdata felix-thinkingdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS merged commit 56d3db0 into apache:dev Jun 27, 2022
zhongjiajie pushed a commit that referenced this pull request Aug 3, 2022
@liudi1184 @zhongjiajie
[fix-10596] Workflow relationship cannot be displayed normally (#10625)
1e498a5 
Workflow relationship cannot be displayed normally

Closes #10596

Co-authored-by: liudadi <liudi@thinkingdata.cn>
(cherry picked from commit 56d3db0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

+1 more reviewer

@felix-thinkingdata felix-thinkingdata felix-thinkingdata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liudi1184 liudi1184

Labels

backend bug Something isn't working first time contributor First-time contributor

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

[Bug] [Api] Workflow relationship cannot be displayed normally

4 participants

@liudi1184 @codecov-commenter @SbloodyS @felix-thinkingdata