Skip to content

[Fix][UI] Fix bytesToSize function calculation error.#10627

Merged
Amy0104 merged 1 commit intoapache:devfrom
Amy0104:fix/10543
Jun 27, 2022
Merged

[Fix][UI] Fix bytesToSize function calculation error.#10627
Amy0104 merged 1 commit intoapache:devfrom
Amy0104:fix/10543

Conversation

@Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Jun 27, 2022

Purpose of the pull request

This pull request fixes bytesToSize function calculation error.

Related Issue

close #10543

@Amy0104 Amy0104 added this to the 3.0.0-beta-3 milestone Jun 27, 2022
@Amy0104 Amy0104 requested a review from songjianet as a code owner June 27, 2022 03:20
@Amy0104 Amy0104 self-assigned this Jun 27, 2022
@Amy0104 Amy0104 added bug Something isn't working UI ui and front end related labels Jun 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10627 (c238960) into dev (719a9d4) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head c238960 differs from pull request most recent head 68348e1. Consider uploading reports for the commit 68348e1 to get more accurate results

@@             Coverage Diff              @@
##                dev   #10627      +/-   ##
============================================
+ Coverage     40.94%   41.07%   +0.12%     
- Complexity     4876     4894      +18     
============================================
  Files           895      895              
  Lines         36212    36223      +11     
  Branches       3987     3987              
============================================
+ Hits          14826    14877      +51     
+ Misses        19921    19883      -38     
+ Partials       1465     1463       -2     
Impacted Files Coverage Δ
...g/apache/dolphinscheduler/spi/utils/JSONUtils.java 73.41% <100.00%> (+55.77%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️
...apache/dolphinscheduler/spi/utils/StringUtils.java 27.27% <0.00%> (+1.01%) ⬆️
...g/apache/dolphinscheduler/spi/utils/DateUtils.java 6.86% <0.00%> (+6.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719a9d4...68348e1. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit a6fc70c into apache:dev Jun 27, 2022
@Amy0104 Amy0104 deleted the fix/10543 branch June 27, 2022 06:10
zhongjiajie pushed a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [ui] bytesToSize

4 participants