Skip to content

Optimize sql script use insert ignore#10700

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_optimizeSqlScript0
Jun 30, 2022
Merged

Optimize sql script use insert ignore#10700
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_optimizeSqlScript0

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

  • use current_timestamp to replace 2021-xx
  • use insert ignore to avoid duplication exception

@SbloodyS SbloodyS added bug Something isn't working backend labels Jun 30, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #10700 (2fbfc9a) into dev (75581b7) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2fbfc9a differs from pull request most recent head 78d9d6b. Consider uploading reports for the commit 78d9d6b to get more accurate results

@@             Coverage Diff              @@
##                dev   #10700      +/-   ##
============================================
- Coverage     40.90%   40.89%   -0.01%     
+ Complexity     4830     4829       -1     
============================================
  Files           897      897              
  Lines         36157    36157              
  Branches       4006     4006              
============================================
- Hits          14789    14787       -2     
- Misses        19897    19898       +1     
- Partials       1471     1472       +1     
Impacted Files Coverage Δ
...r/server/master/runner/MasterSchedulerService.java 0.00% <ø> (ø)
...nscheduler/service/process/ProcessServiceImpl.java 30.28% <ø> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75581b7...78d9d6b. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun
Copy link
Member Author

This change will not modify the schema.

@ruanwenjun ruanwenjun merged commit 1b86394 into apache:dev Jun 30, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_optimizeSqlScript0 branch June 30, 2022 11:05
welsh-wen pushed a commit to welsh-wen/dolphinscheduler that referenced this pull request Jul 2, 2022
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 5, 2022
@zhongjiajie zhongjiajie modified the milestones: 3.0.0-release, 3.1.0-alpha Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants