[Optimization] Calculate global parameter and local parameter at master.#10704
Merged
lenboo merged 6 commits intoapache:devfrom Jun 30, 2022
Merged
[Optimization] Calculate global parameter and local parameter at master.#10704lenboo merged 6 commits intoapache:devfrom
lenboo merged 6 commits intoapache:devfrom
Conversation
WangJPLeo
requested review from
SbloodyS,
caishunfeng,
ruanwenjun and
zhuangchong
as code owners
WangJPLeo
changed the title
caishunfeng
reviewed
Jun 30, 2022
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...er-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/ParamUtils.java
Outdated
Show resolved
Hide resolved
...ask-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/ParameterUtils.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
lenboo
requested changes
Jun 30, 2022
...er-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/ParamUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #10704 +/- ##
============================================
- Coverage 40.89% 40.84% -0.06%
+ Complexity 4830 4827 -3
============================================
Files 897 897
Lines 36157 36128 -29
Branches 4006 3987 -19
============================================
- Hits 14788 14756 -32
- Misses 19898 19907 +9
+ Partials 1471 1465 -6
Continue to review full report at Codecov.
|
ruanwenjun
reviewed
Jun 30, 2022
...er/src/main/java/org/apache/dolphinscheduler/server/builder/TaskExecutionContextBuilder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/dolphinscheduler/service/expand/DolphinSchedulerCuringGlobalParams.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
1 similar comment
|
Kudos, SonarCloud Quality Gate passed! |
ruanwenjun
changed the title
Contributor
|
+1 |
welsh-wen
pushed a commit
to welsh-wen/dolphinscheduler
that referenced
this pull request
Jul 2, 2022
…er. (apache#10704) * Global parameter and local parameter calculation external expansion. * k8s task ut fix. * TimePlaceholderUtils import DateUtils fix * follow the review comments to fix. * follow the review comments to fix. * e2e rerun
zhongjiajie
pushed a commit
to zhongjiajie/dolphinscheduler
that referenced
this pull request
Jul 5, 2022
…er. (apache#10704) * Global parameter and local parameter calculation external expansion. * k8s task ut fix. * TimePlaceholderUtils import DateUtils fix * follow the review comments to fix. * follow the review comments to fix. * e2e rerun
ruanwenjun
pushed a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
close #10703
Verify this pull request
Manually verified the change by testing locally.