[Optimization]Optimize some details of MLFlow task plugin #10740#10739
[Optimization]Optimize some details of MLFlow task plugin #10740#10739caishunfeng merged 3 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10739 +/- ##
============================================
- Coverage 40.71% 39.93% -0.79%
- Complexity 4820 4843 +23
============================================
Files 900 902 +2
Lines 36143 37270 +1127
Branches 3982 4338 +356
============================================
+ Hits 14717 14885 +168
- Misses 19972 20910 +938
- Partials 1454 1475 +21
Continue to review full report at Codecov.
|
|
restart the failed tests |
|
I think that will not be released until version 3.1.0-alpha |
...sk-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowParameters.java
Outdated
Show resolved
Hide resolved
…main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowParameters.java
|
@jieguangzhou I change some of your code and you could task a look at #10739 (comment) |
you are right. |
Thanks, your code is better. I learned thaty |
|
|
||
| } | ||
|
|
||
| public int checkDockerHealth() throws Exception { |
There was a problem hiding this comment.
I think it's a general method and can move into ProcessUtils, WDYT?
There was a problem hiding this comment.
I can't make a sound recommendation because I'm not sure if there are other components that use this function. WDYT @zhongjiajie
...ler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowTask.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
|
@caishunfeng PTAL, thanks |
|
Thanks all |
apache#10739) * Optimize some details of MLFlow task plugin * Update dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowParameters.java * fix some nips Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>








Purpose of the pull request
Optimize some details of the MLFlow task plugin
close: #10740
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: