Skip to content

[Feature-10594][ui] Data Quality Result Display Optimize#10835

Merged
Amy0104 merged 1 commit intoapache:devfrom
shangeyao:Feature-10594
Jul 8, 2022
Merged

[Feature-10594][ui] Data Quality Result Display Optimize#10835
Amy0104 merged 1 commit intoapache:devfrom
shangeyao:Feature-10594

Conversation

@shangeyao
Copy link
Contributor

@shangeyao shangeyao commented Jul 7, 2022

Purpose of the pull request

close #10594

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #10835 (3fee2f6) into dev (b8a90d8) will increase coverage by 0.00%.
The diff coverage is 52.38%.

❗ Current head 3fee2f6 differs from pull request most recent head 7b4ade9. Consider uploading reports for the commit 7b4ade9 to get more accurate results

@@            Coverage Diff            @@
##                dev   #10835   +/-   ##
=========================================
  Coverage     40.63%   40.63%           
- Complexity     4818     4823    +5     
=========================================
  Files           913      913           
  Lines         36306    36358   +52     
  Branches       3994     4004   +10     
=========================================
+ Hits          14752    14774   +22     
- Misses        20082    20102   +20     
- Partials       1472     1482   +10     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/k8s/K8sClientService.java 4.25% <0.00%> (-2.13%) ⬇️
...uler/api/service/impl/K8SNamespaceServiceImpl.java 68.71% <51.21%> (-5.68%) ⬇️
...rg/apache/dolphinscheduler/api/k8s/K8sManager.java 58.53% <54.83%> (+11.16%) ⬆️
...scheduler/api/service/impl/ClusterServiceImpl.java 85.71% <58.33%> (-2.57%) ⬇️
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 75.40% <66.66%> (-1.26%) ⬇️
...heduler/api/controller/K8sNamespaceController.java 80.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
.../org/apache/dolphinscheduler/common/Constants.java 83.33% <100.00%> (+0.72%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a90d8...7b4ade9. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS added bug Something isn't working UI ui and front end related labels Jul 7, 2022
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit 4d07efd into apache:dev Jul 8, 2022
zhongjiajie pushed a commit to zhongjiajie/dolphinscheduler that referenced this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] [UI] Data Quality Result Display Optimize

4 participants