Skip to content

[Doc][Upgrade] Fix tiny error in upgrade docs#10847

Merged
davidzollo merged 2 commits intoapache:devfrom
EricGao888:Fix-10846
Jul 9, 2022
Merged

[Doc][Upgrade] Fix tiny error in upgrade docs#10847
davidzollo merged 2 commits intoapache:devfrom
EricGao888:Fix-10846

Conversation

@EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • Quote example datasource url value in upgrade docs.

Verify this pull request

  • Verified by manual test.

export DATABASE=${DATABASE:-mysql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_URL=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
export SPRING_DATASOURCE_URL="jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems using &useSSL=false in the connection param is necessary too. I have to add it to connect mysql server 5.7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thx for pointing this out. I will add it in the next commit.

export DATABASE=${DATABASE:-mysql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_URL=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
export SPRING_DATASOURCE_URL="jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems using &useSSL=false in the connection param is necessary too. I have to add it to connect mysql server 5.7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it

@EricGao888 EricGao888 requested a review from zhongjiajie July 8, 2022 08:05
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jul 8, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidzollo davidzollo merged commit 1387fb3 into apache:dev Jul 9, 2022
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jul 9, 2022
* [Doc][Upgrade] Fix tiny error in upgrade docs (apache#10846)

* [Doc][Upgrade] Add useSSL=false and fix typo in upgrade docs (apache#10846)
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jul 18, 2022
* [Doc][Upgrade] Fix tiny error in upgrade docs (apache#10846)

* [Doc][Upgrade] Add useSSL=false and fix typo in upgrade docs (apache#10846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][Upgrade] Tiny error in upgrade docs

4 participants