Skip to content

[Fix-10863] Command execution result data statistics remove userId condition.#10864

Merged
caishunfeng merged 2 commits intoapache:devfrom
WangJPLeo:command-state-count
Jul 10, 2022
Merged

[Fix-10863] Command execution result data statistics remove userId condition.#10864
caishunfeng merged 2 commits intoapache:devfrom
WangJPLeo:command-state-count

Conversation

@WangJPLeo
Copy link
Contributor

Purpose of the pull request

Command execution result data statistics remove userId condition.

Brief change log

close #10863

Verify this pull request

Manually verified the change by testing locally.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #10864 (105eb2a) into dev (c829738) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #10864      +/-   ##
============================================
- Coverage     40.66%   40.60%   -0.07%     
- Complexity     4826     4828       +2     
============================================
  Files           913      915       +2     
  Lines         36306    36435     +129     
  Branches       3989     3999      +10     
============================================
+ Hits          14765    14793      +28     
- Misses        20068    20160      +92     
- Partials       1473     1482       +9     
Impacted Files Coverage Δ
...uler/api/service/impl/DataAnalysisServiceImpl.java 81.98% <100.00%> (+0.73%) ⬆️
...e/dolphinscheduler/service/queue/TaskPriority.java 50.66% <0.00%> (-3.62%) ⬇️
...rver/master/dispatch/context/ExecutionContext.java 71.42% <0.00%> (-1.91%) ⬇️
.../org/apache/dolphinscheduler/common/graph/DAG.java 95.23% <0.00%> (-0.77%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.08% <0.00%> (-0.70%) ⬇️
...nscheduler/service/process/ProcessServiceImpl.java 29.93% <0.00%> (-0.27%) ⬇️
.../server/master/runner/WorkflowExecuteRunnable.java 7.98% <0.00%> (-0.23%) ⬇️
.../server/master/runner/StateWheelExecuteThread.java 0.45% <0.00%> (-0.01%) ⬇️
...er/server/master/runner/FailoverExecuteThread.java 0.00% <0.00%> (ø)
...ver/master/consumer/TaskPriorityQueueConsumer.java 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c829738...105eb2a. Read the comment docs.

@caishunfeng
Copy link
Contributor

Hi @WangJPLeo I can't get the point of the The number of failed commands is incorrectly counted, please add some details for it, thanks.
BTW, I think the userId condition is necessary because the user can only see the data they have.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lenboo
Copy link
Contributor

lenboo commented Jul 9, 2022

Hi @WangJPLeo I can't get the point of the The number of failed commands is incorrectly counted, please add some details for it, thanks. BTW, I think the userId condition is necessary because the user can only see the data they have.

Yes, I think the login user can only see the processes with permissions.

@WangJPLeo
Copy link
Contributor Author

Hi @WangJPLeo I can't get the point of the The number of failed commands is incorrectly counted, please add some details for it, thanks. BTW, I think the userId condition is necessary because the user can only see the data they have.

After the resource permissions are refactored, the user-related projects are uniformly obtained in the getProjectIds method, so it is not necessary to use the user ID to query after obtaining the user-related projects. The displayed error command statistics are inaccurate because the user ID association is added. @caishunfeng @lenboo

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 3756a23 into apache:dev Jul 10, 2022
ruanwenjun pushed a commit to ruanwenjun/dolphinscheduler that referenced this pull request Jul 12, 2022
…ndition. (apache#10864)

* Command execution result data statistics remove userId condition.

* e2e rerun

(cherry picked from commit 3756a23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG-BE][Statistics Module] The number of failed commands is incorrectly counted

4 participants