[FIX-10784][Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop#10888
Merged
caishunfeng merged 6 commits intoapache:devfrom Jul 13, 2022
pinkhello:closed-10784
Merged
[FIX-10784][Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop#10888caishunfeng merged 6 commits intoapache:devfrom pinkhello:closed-10784
caishunfeng merged 6 commits intoapache:devfrom
pinkhello:closed-10784
Conversation
pinkhello
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #10888 +/- ##
=========================================
Coverage 40.31% 40.31%
- Complexity 4857 4859 +2
=========================================
Files 943 943
Lines 36994 37007 +13
Branches 4059 4060 +1
=========================================
+ Hits 14913 14919 +6
- Misses 20578 20585 +7
Partials 1503 1503
Continue to review full report at Codecov.
|
Contributor
|
I had rerun the failed CI. |
Contributor
Author
I'll deal with it |
Contributor
Author
|
Please CR @caishunfeng |
Tianqi-Dotes
previously approved these changes
Jul 13, 2022
Member
Tianqi-Dotes
left a comment
Tianqi-Dotes
left a comment
There was a problem hiding this comment.
LGTM,GOOD JOB
Please check e2e failures. thanks!
dolphinscheduler-e2e-case: There are test failures.
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
ok! done! |
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Jul 18, 2022
…lert process loop (apache#10888) * closed 10784 [Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Jul 18, 2022
…lert process loop (apache#10888) * closed 10784 [Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop
ruanwenjun
pushed a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 1, 2022
…lert process loop (apache#10888) (apache#30) * closed 10784 [Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop Co-authored-by: pinkhello <lee123lee123@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
closed #10784
Brief change log
Verify this pull request
This pull request is already covered by existing tests, such as dolphinscheduler-alert/dolphinscheduler-alert-server/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderServiceTest.java.