Skip to content

[Fix-10909] Returns executionStatus for each process instance status and access token module support.#10922

Merged
caishunfeng merged 8 commits intoapache:devfrom
WangJPLeo:execution-status-token]
Jul 13, 2022
Merged

[Fix-10909] Returns executionStatus for each process instance status and access token module support.#10922
caishunfeng merged 8 commits intoapache:devfrom
WangJPLeo:execution-status-token]

Conversation

@WangJPLeo
Copy link
Contributor

@WangJPLeo WangJPLeo commented Jul 13, 2022 •
edited
Loading

Purpose of the pull request

1.Returns executionStatus for each process instance status.
2.Add accessToken resource module.

replace #10910
There is a lot of check style processing in the pr of 10910, replace this pr with 10910.

Brief change log

close #10909

Verify this pull request

Manually verified the change by testing locally.

@WangJPLeo WangJPLeo mentioned this pull request Jul 13, 2022
Closed
caishunfeng
caishunfeng previously approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng
Copy link
Contributor

caishunfeng commented Jul 13, 2022

@WangJPLeo please close the old pr.

@WangJPLeo
Copy link
Contributor Author

WangJPLeo commented Jul 13, 2022

@WangJPLeo please close the old pr.
ok.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #10922 (55083c0) into dev (427c585) will decrease coverage by 0.00%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##                dev   #10922      +/-   ##
============================================
- Coverage     40.31%   40.31%   -0.01%     
  Complexity     4858     4858              
============================================
  Files           943      943              
  Lines         36994    37008      +14     
  Branches       4059     4060       +1     
============================================
+ Hits          14914    14919       +5     
- Misses        20578    20589      +11     
+ Partials       1502     1500       -2
Impacted Files Coverage Δ
.../server/master/runner/WorkflowExecuteRunnable.java 7.79% <0.00%> (-0.02%) ⬇️
...duler/api/service/impl/AccessTokenServiceImpl.java 89.02% <92.85%> (+5.30%) ⬆️
...duler/api/service/impl/EnvironmentServiceImpl.java 78.78% <0.00%> (-1.74%) ⬇️
...permission/ResourcePermissionCheckServiceImpl.java 67.44% <0.00%> (-0.82%) ⬇️
...org/apache/dolphinscheduler/alert/AlertConfig.java 0.00% <0.00%> (ø)
...che/dolphinscheduler/alert/AlertSenderService.java 54.74% <0.00%> (+0.41%) ⬆️
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427c585...55083c0. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.2% 84.2% Coverage
0.0% 0.0% Duplication

caishunfeng
caishunfeng approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 9f34a83 into apache:dev Jul 13, 2022
SnowMoon-Dev pushed a commit to SnowMoon-Dev/dolphinscheduler that referenced this pull request Jul 14, 2022
@WangJPLeo @SnowMoon-Dev
[Fix-10909] Returns executionStatus for each process instance status …
821589d 
…and access token module support. (apache#10922)

* Returns executionStatus for each process instance status and access token module support
@ruanwenjun ruanwenjun added this to the 3.0.0-release milestone Jul 14, 2022
ruanwenjun pushed a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
@WangJPLeo
[Fix-10909] Returns executionStatus for each process instance status …
865c3dc 
…and access token module support. (apache#10922)

* Returns executionStatus for each process instance status and access token module support

(cherry picked from commit 9f34a83)
@zhongjiajie zhongjiajie modified the milestones: 3.0.0-release, 3.1.0-alpha Aug 3, 2022
@zhongjiajie
Copy link
Member

zhongjiajie commented Aug 3, 2022

@ruanwenjun it is related about permission so I change to version 3.1.0

@ruanwenjun
Copy link
Member

ruanwenjun commented Aug 3, 2022

@ruanwenjun it is related about permission so I change to version 3.1.0

OK, this PR also fixes a bug, I will submit a PR to 3.0.0-prepare to fix.

@ruanwenjun
Copy link
Member

ruanwenjun commented Aug 3, 2022

@ruanwenjun it is related about permission so I change to version 3.1.0

OK, this PR also fixes a bug, I will submit a PR to 3.0.0-prepare to fix.

Already been fiexd at 3.0.0-prepare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

No one assigned

Labels

backend

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

[Bug] Stop process instance state is incorrect.

5 participants

@WangJPLeo @caishunfeng @codecov-commenter @zhongjiajie @ruanwenjun