Skip to content

Kill task when we do master failover to avoid task lost#10997

Merged
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixFailoverMasterDoesNotCheckWorker
Jul 15, 2022
Merged

Kill task when we do master failover to avoid task lost#10997
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_fixFailoverMasterDoesNotCheckWorker

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #10997 (28da177) into dev (4ff8eaa) will increase coverage by 0.03%.
The diff coverage is 7.69%.

@@             Coverage Diff              @@
##                dev   #10997      +/-   ##
============================================
+ Coverage     40.31%   40.34%   +0.03%     
- Complexity     4858     4863       +5     
============================================
  Files           943      943              
  Lines         37015    37038      +23     
  Branches       4061     4063       +2     
============================================
+ Hits          14922    14944      +22     
+ Misses        20593    20591       -2     
- Partials       1500     1503       +3     
Impacted Files Coverage Δ
...heduler/remote/command/TaskKillRequestCommand.java 0.00% <0.00%> (ø)
...r/server/master/service/MasterFailoverService.java 56.77% <10.00%> (-3.78%) ⬇️
...duler/plugin/task/zeppelin/ZeppelinParameters.java 81.25% <0.00%> (-3.37%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...inscheduler/plugin/task/zeppelin/ZeppelinTask.java 48.05% <0.00%> (-0.64%) ⬇️
...che/dolphinscheduler/api/python/PythonGateway.java 21.64% <0.00%> (ø)
.../dolphinscheduler/plugin/task/datax/DataxTask.java 0.00% <0.00%> (ø)
...olphinscheduler/plugin/task/mlflow/MlflowTask.java 60.39% <0.00%> (+1.21%) ⬆️
...erver/master/processor/queue/TaskEventService.java 80.35% <0.00%> (+5.35%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff8eaa...28da177. Read the comment docs.

@ruanwenjun ruanwenjun added this to the 3.0.0-release milestone Jul 15, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

53.8% 53.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 998e4d7 into apache:dev Jul 15, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixFailoverMasterDoesNotCheckWorker branch July 15, 2022 12:35
ruanwenjun added a commit that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants