Skip to content

Add dolphinscheduler-bom to manage the dependency version#11025

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addBom
Jul 20, 2022
Merged

Add dolphinscheduler-bom to manage the dependency version#11025
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addBom

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jul 18, 2022

Purpose of the pull request

Add dolphinscheduler-bom to manage the dependency, other module need to rely on this module to get the version of third-part dependencies.

close #10891

Brief change log

  • Add a new module dolphinscheduler-bom, and move the dependency management from root pom to bom
  • Add bom to other module

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@ruanwenjun ruanwenjun requested a review from kezhenxu94 as a code owner July 18, 2022 07:34
@ruanwenjun ruanwenjun marked this pull request as draft July 18, 2022 07:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #11025 (6e21b59) into dev (ff34393) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6e21b59 differs from pull request most recent head a48adc8. Consider uploading reports for the commit a48adc8 to get more accurate results

@@            Coverage Diff            @@
##                dev   #11025   +/-   ##
=========================================
  Coverage     40.35%   40.36%           
+ Complexity     4867     4865    -2     
=========================================
  Files           943      943           
  Lines         37061    37061           
  Branches       4067     4068    +1     
=========================================
+ Hits          14955    14958    +3     
+ Misses        20603    20600    -3     
  Partials       1503     1503           
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 80.35% <0.00%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34393...a48adc8. Read the comment docs.

@github-actions github-actions bot added the UI ui and front end related label Jul 19, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun marked this pull request as ready for review July 19, 2022 07:17
@ruanwenjun ruanwenjun merged commit 5e9c7da into apache:dev Jul 20, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_addBom branch July 20, 2022 02:37
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
* Add dolphinscheduler-bom to manage the dependency version (apache#11025)

(cherry picked from commit 5e9c7da)

* Add bom module

* Add base loop task execotor and http template parser (apache#11137)

* Add base loop task execotor and http template parser

* Add JsonPathUtils

(cherry picked from commit c7789bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Module] Add new module dolphinScheduler-bom to manage the third part dependencies

3 participants