Skip to content

[Improve] Hide Change Pwd Page When Login With LDAP#11041

Merged
caishunfeng merged 6 commits intoapache:devfrom
qingwli:ldap
Jul 20, 2022
Merged

[Improve] Hide Change Pwd Page When Login With LDAP#11041
caishunfeng merged 6 commits intoapache:devfrom
qingwli:ldap

Conversation

@qingwli
Copy link
Member

@qingwli qingwli commented Jul 19, 2022

Purpose of the pull request

Hide Change Pwd Page When Login With LDAP. I have finished the back-end part. When login will return securityConfigType

Front part supported by #11029

Part of #10425

Brief change log

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

  • dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoginControllerTest.java.

close #10507

@codecov-commenter
Copy link

Codecov Report

Merging #11041 (9dfe2a1) into dev (ff34393) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #11041      +/-   ##
============================================
+ Coverage     40.35%   40.36%   +0.01%     
+ Complexity     4867     4865       -2     
============================================
  Files           943      943              
  Lines         37061    37059       -2     
  Branches       4067     4062       -5     
============================================
+ Hits          14955    14960       +5     
+ Misses        20603    20596       -7     
  Partials       1503     1503              
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 83.33% <ø> (ø)
.../dolphinscheduler/api/security/SecurityConfig.java 70.00% <100.00%> (+1.57%) ⬆️
...duler/api/security/impl/AbstractAuthenticator.java 100.00% <100.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...rver/master/runner/task/BlockingTaskProcessor.java 75.60% <0.00%> (-0.30%) ⬇️
...eduler/api/service/impl/DataSourceServiceImpl.java 29.49% <0.00%> (ø)
.../dolphinscheduler/plugin/task/datax/DataxTask.java 0.00% <0.00%> (ø)
...cheduler/plugin/task/api/ShellCommandExecutor.java 0.00% <0.00%> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <0.00%> (+0.05%) ⬆️
...hinscheduler/plugin/alert/wechat/WeChatSender.java 29.78% <0.00%> (+0.20%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34393...9dfe2a1. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@qingwli
Copy link
Member Author

qingwli commented Jul 19, 2022

PTAL @SbloodyS @caishunfeng

@qingwli
Copy link
Member Author

qingwli commented Jul 19, 2022

The front part has merged into dev due #11029

@songjianet songjianet added this to the 3.1.0-alpha milestone Jul 19, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 28b40da into apache:dev Jul 20, 2022
@qingwli qingwli deleted the ldap branch September 7, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][LDAP] Hide Change Pwd Page When Login With LDAP

4 participants