Skip to content

[Refactor][UI] Refactor time display of token manage use datatable render function#11078

Merged
devosend merged 1 commit intoapache:devfrom
devosend:refactor/token-manage
Jul 21, 2022
Merged

[Refactor][UI] Refactor time display of token manage use datatable render function#11078
devosend merged 1 commit intoapache:devfrom
devosend:refactor/token-manage

Conversation

@devosend
Copy link
Contributor

Purpose of the pull request

ref: #11076

@devosend devosend added UI ui and front end related refactor labels Jul 21, 2022
@devosend devosend added this to the 3.1.0-alpha milestone Jul 21, 2022
@devosend devosend self-assigned this Jul 21, 2022
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #11078 (0820393) into dev (25ded1e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11078      +/-   ##
============================================
- Coverage     40.30%   40.28%   -0.03%     
  Complexity     4854     4854              
============================================
  Files           943      943              
  Lines         37055    37055              
  Branches       4073     4072       -1     
============================================
- Hits          14935    14927       -8     
- Misses        20612    20619       +7     
- Partials       1508     1509       +1     
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet linked an issue Jul 21, 2022 that may be closed by this pull request
3 tasks
@devosend devosend merged commit 594f005 into apache:dev Jul 21, 2022
@devosend devosend deleted the refactor/token-manage branch July 21, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor][UI] Use render function of DataTable to render time

4 participants