[Fix-10918] Close datasource when expire from guava cache#11120
Merged
ruanwenjun merged 3 commits intoapache:devfrom Jul 23, 2022
Merged
[Fix-10918] Close datasource when expire from guava cache#11120ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun merged 3 commits intoapache:devfrom
Conversation
3 tasks
ruanwenjun
force-pushed
the
dev_wenjun_patch10918
branch
from
518f401 to
6d10d6c
Compare
SbloodyS
reviewed
Jul 23, 2022
.../java/org/apache/dolphinscheduler/plugin/datasource/api/plugin/DataSourceClientProvider.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #11120 +/- ##
============================================
- Coverage 40.35% 40.34% -0.01%
+ Complexity 4874 4872 -2
============================================
Files 950 950
Lines 37184 37187 +3
Branches 4077 4079 +2
============================================
- Hits 15005 15004 -1
- Misses 20669 20673 +4
Partials 1510 1510
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
SonarCloud Quality Gate failed. |
caishunfeng
pushed a commit
that referenced
this pull request
Jul 27, 2022
* Close datasource when expire from guava cache * Remove duplicate datasource in HiveDataSourceClient
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 4, 2022
* Close datasource when expire from guava cache * Remove duplicate datasource in HiveDataSourceClient (cherry picked from commit 71cf7e1)
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 12, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
If the
close #10918
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: