[fix-11176][Bug] [script] dolphinscheduler-daemon.sh Status error #11176 by TangTangGrit · Pull Request #11182 · apache/dolphinscheduler

TangTangGrit · 2022-07-27T14:41:02Z

Purpose of the pull request

close #11176

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

…rStyle into dev

dolphinscheduler-ui/src/assets/styles/default.scss

codecov-commenter · 2022-07-28T01:50:34Z

Codecov Report

Merging #11182 (b669243) into dev (a52d1b4) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11182      +/-   ##
============================================
- Coverage     40.23%   40.16%   -0.07%     
- Complexity     4924     4947      +23     
============================================
  Files           982      988       +6     
  Lines         37567    37688     +121     
  Branches       4129     4135       +6     
============================================
+ Hits          15116    15139      +23     
- Misses        20915    21007      +92     
- Partials       1536     1542       +6

Impacted Files	Coverage Δ
...erver/master/processor/queue/TaskEventService.java	`69.64% <0.00%> (-10.72%)`	⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java	`50.00% <0.00%> (-2.78%)`	⬇️
...pache/dolphinscheduler/common/utils/DateUtils.java	`74.83% <0.00%> (-0.17%)`	⬇️
.../dolphinscheduler/plugin/task/datax/DataxTask.java	`0.00% <0.00%> (ø)`
...ler/plugin/task/api/loop/BaseLoopTaskExecutor.java	`0.00% <0.00%> (ø)`
...loop/template/http/HttpLoopTaskInstanceStatus.java	`0.00% <0.00%> (ø)`
...eduler/plugin/task/chunjun/ChunJunTaskChannel.java	`0.00% <0.00%> (ø)`
...plugin/task/chunjun/ChunJunTaskChannelFactory.java	`0.00% <0.00%> (ø)`
...ugin/task/chunjun/ChunJunTaskExecutionContext.java	`0.00% <0.00%> (ø)`
...cheduler/plugin/task/chunjun/ChunJunConstants.java	`0.00% <0.00%> (ø)`
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

zhongjiajie · 2022-07-29T02:50:31Z

I wonder, can we directly check the pid file of each service?

SbloodyS · 2022-07-29T02:52:07Z

I wonder, can we directly check the pid file of each service?

That sounds more reasonable to me.

TangTangGrit · 2022-07-29T02:57:15Z

I wonder, can we directly check the pid file of each service?

I have checked. There is no individual service PID

SbloodyS · 2022-07-29T03:05:53Z

I wonder, can we directly check the pid file of each service?

I have checked. There is no individual service PID

We do have it. You can take a look at

dolphinscheduler/script/dolphinscheduler-daemon.sh

Lines 63 to 87 in 4b43d62

    
           pid=$DOLPHINSCHEDULER_HOME/$command/pid 
        
           cd $DOLPHINSCHEDULER_HOME/$command 
        
           if [ "$command" = "api-server" ]; then 
        
             log=$DOLPHINSCHEDULER_HOME/api-server/logs/$command-$HOSTNAME.out 
        
           elif [ "$command" = "master-server" ]; then 
        
             log=$DOLPHINSCHEDULER_HOME/master-server/logs/$command-$HOSTNAME.out 
        
           elif [ "$command" = "worker-server" ]; then 
        
             log=$DOLPHINSCHEDULER_HOME/worker-server/logs/$command-$HOSTNAME.out 
        
           elif [ "$command" = "alert-server" ]; then 
        
             log=$DOLPHINSCHEDULER_HOME/alert-server/logs/$command-$HOSTNAME.out 
        
           elif [ "$command" = "standalone-server" ]; then 
        
             log=$DOLPHINSCHEDULER_HOME/standalone-server/logs/$command-$HOSTNAME.out 
        
           else 
        
             echo "Error: No command named '$command' was found." 
        
             exit 1 
        
           fi 
        
           case $startStop in 
        
             (start) 
        
               echo starting $command, logging to $DOLPHINSCHEDULER_LOG_DIR 
        
               overwrite_server_env "${command}" 
        
               nohup /bin/bash "$DOLPHINSCHEDULER_HOME/$command/bin/start.sh" > $log 2>&1 & 
        
               echo $! > $pid

TangTangGrit · 2022-07-29T06:32:42Z

I wonder, can we directly check the pid file of each service?

I have checked. There is no individual service PID

We do have it. You can take a look at

dolphinscheduler/script/dolphinscheduler-daemon.sh

Lines 63 to 87 in 4b43d62

pid=$DOLPHINSCHEDULER_HOME/$command/pid

cd $DOLPHINSCHEDULER_HOME/$command

if [ "$command" = "api-server" ]; then

log=$DOLPHINSCHEDULER_HOME/api-server/logs/$command-$HOSTNAME.out

elif [ "$command" = "master-server" ]; then

log=$DOLPHINSCHEDULER_HOME/master-server/logs/$command-$HOSTNAME.out

elif [ "$command" = "worker-server" ]; then

log=$DOLPHINSCHEDULER_HOME/worker-server/logs/$command-$HOSTNAME.out

elif [ "$command" = "alert-server" ]; then

log=$DOLPHINSCHEDULER_HOME/alert-server/logs/$command-$HOSTNAME.out

elif [ "$command" = "standalone-server" ]; then

log=$DOLPHINSCHEDULER_HOME/standalone-server/logs/$command-$HOSTNAME.out

else

echo "Error: No command named '$command' was found."

exit 1

fi

case $startStop in

(start)

echo starting $command, logging to $DOLPHINSCHEDULER_LOG_DIR

overwrite_server_env "${command}"

nohup /bin/bash "$DOLPHINSCHEDULER_HOME/$command/bin/start.sh" > $log 2>&1 &

echo $! > $pid

I'm based on advice. The code has been reworked. But what am I supposed to do now

SbloodyS · 2022-07-29T06:33:40Z

What i mean is we can get the pid of each service through the pid file to verify whether the process is alive. @TangTangGrit

TangTangGrit · 2022-07-29T06:35:21Z

What i mean is we can get the pid of each service through the pid file to verify whether the process is alive. @TangTangGrit

Yes, that's what I did

SbloodyS · 2022-07-29T06:38:11Z

What i mean is we can get the pid of each service through the pid file to verify whether the process is alive. @TangTangGrit

Yes, that's what I did

I see. Sorry, I was careless and didn't take a close look at your modification.

SbloodyS

LGTM

fix the alert-server and standalone-server class

SbloodyS · 2022-07-29T06:56:29Z

script/dolphinscheduler-daemon.sh

+      state="STOP"
+      state="[ \033[1;31m $state \033[0m ]"
+      if [ -f $pid ]; then
+        TARGET_PID=`cat $pid`
+        serverCount=`ps -p $TARGET_PID | wc -l`
+        if [[ $serverCount -gt 1 ]];then
+          state="RUNNING"
+          state="[ \033[1;32m $state \033[0m ]"
+        fi
+      echo -e "$command  $state"
+      fi
+      ;;
+      


I think we should not do this. The previous version is enough. Please rollback it.

This is the,This is verified by obtaining the PID of each service from the PID file.

Just as you said

Yes. But the old method also realizes this function. We should try to reduce large-scale modifications to ensure stability.

@SbloodyS I think this is better than the old, more beautiful ^_^

This change is want to used the pid as filter rather than use the process name.
If the pid file has been deleted, this method may return an incorrect status.

sonarqubecloud · 2022-07-30T15:58:29Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

50.0% Coverage
0.0% Duplication

ruanwenjun · 2022-08-17T14:32:08Z

script/dolphinscheduler-daemon.sh

-    ;;
-
+      state="STOP"
+      state="[ \033[1;31m $state \033[0m ]"


Why you remove the comment # font color - red?

github-actions · 2023-10-24T00:19:07Z

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions · 2023-10-31T00:19:32Z

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

tianzhihao and others added 4 commits July 23, 2022 08:59

Modified the style of the overwriting font

82f5471

Merge branch 'apache:dev' into dev

c1cd000

Increase the value of class in dolphinscheduler-daemon.sh

55c46e3

Merge branch 'dev' of https://github.com/TangTangGrit/dolphinschedule…

9888679

…rStyle into dev

TangTangGrit requested review from Amy0104, EricGao888, SbloodyS, caishunfeng, songjianet and zhongjiajie as code owners July 27, 2022 14:41

github-actions bot added backend UI ui and front end related labels Jul 27, 2022

SbloodyS reviewed Jul 28, 2022

View reviewed changes

dolphinscheduler-ui/src/assets/styles/default.scss Show resolved Hide resolved

SbloodyS added the first time contributor First-time contributor label Jul 28, 2022

SbloodyS assigned TangTangGrit Jul 28, 2022

Merge branch 'apache:dev' into dev

aa14f56

Update default.scss

8fd27b5

SbloodyS removed request for Amy0104 and songjianet July 28, 2022 01:58

github-actions bot removed the UI ui and front end related label Jul 28, 2022

zhongjiajie added this to the 3.0.0-release milestone Jul 29, 2022

zhongjiajie added the priority:high label Jul 29, 2022

SbloodyS previously approved these changes Jul 29, 2022

View reviewed changes

Update dolphinscheduler-daemon.sh

a3f488e

fix the alert-server and standalone-server class

SbloodyS dismissed their stale review via a3f488e July 29, 2022 06:42

SbloodyS previously approved these changes Jul 29, 2022

View reviewed changes

Update dolphinscheduler-daemon.sh

7e03260

TangTangGrit dismissed SbloodyS’s stale review via 7e03260 July 29, 2022 06:49

SbloodyS reviewed Jul 29, 2022

View reviewed changes

Update dolphinscheduler-daemon.sh

b669243

zhongjiajie modified the milestones: 3.0.0, 3.0.1 Aug 5, 2022

apache deleted a comment from luojieio Aug 17, 2022

ruanwenjun reviewed Aug 17, 2022

View reviewed changes

caishunfeng added the bug Something isn't working label Sep 16, 2022

zhuangchong modified the milestones: 3.0.1, 3.0.2 Sep 18, 2022

github-actions bot added the Stale label Oct 24, 2023

github-actions bot closed this Oct 31, 2023

Conversation

TangTangGrit commented Jul 27, 2022

Purpose of the pull request

Brief change log

Verify this pull request

Uh oh!

Uh oh!

codecov-commenter commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zhongjiajie commented Jul 29, 2022

Uh oh!

SbloodyS commented Jul 29, 2022

Uh oh!

TangTangGrit commented Jul 29, 2022 • edited by SbloodyS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SbloodyS commented Jul 29, 2022

Uh oh!

TangTangGrit commented Jul 29, 2022

Uh oh!

SbloodyS commented Jul 29, 2022

Uh oh!

TangTangGrit commented Jul 29, 2022

Uh oh!

SbloodyS commented Jul 29, 2022

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

TangTangGrit Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

TangTangGrit Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

SbloodyS Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

davidzollo Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

ruanwenjun Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 30, 2022

Uh oh!

ruanwenjun Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 24, 2023

Uh oh!

github-actions bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov-commenter commented Jul 28, 2022 •

edited

Loading

TangTangGrit commented Jul 29, 2022 •

edited by SbloodyS

Loading