Skip to content

Add alertPluginInstanceId in AlertInfo#11231

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addAlertPluginInstanceIdInAlertInfo
Aug 1, 2022
Merged

Add alertPluginInstanceId in AlertInfo#11231
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_addAlertPluginInstanceIdInAlertInfo

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Aug 1, 2022

Purpose of the pull request

In some case we need to use alertPluginInstanceId in alert plugin

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addAlertPluginInstanceIdInAlertInfo branch from da7ada2 to 34c7e61 Compare August 1, 2022 08:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #11231 (34c7e61) into dev (9a53c6a) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                dev   #11231      +/-   ##
============================================
- Coverage     40.15%   40.14%   -0.02%     
+ Complexity     4951     4949       -2     
============================================
  Files           988      988              
  Lines         37733    37721      -12     
  Branches       4149     4148       -1     
============================================
- Hits          15153    15143      -10     
+ Misses        21039    21036       -3     
- Partials       1541     1542       +1     
Impacted Files Coverage Δ
...che/dolphinscheduler/alert/AlertSenderService.java 51.87% <88.88%> (-1.92%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit caa6287 into apache:dev Aug 1, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_addAlertPluginInstanceIdInAlertInfo branch August 1, 2022 09:32
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
@zhongjiajie zhongjiajie added this to the 3.1.0-alpha milestone Aug 2, 2022
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants