[Improvement][UI] Scrolling will be applied to parent model on editor scrolled to top/bottom#11335
Merged
songjianet merged 1 commit intoapache:devfrom Aug 8, 2022
hezean:editor-scroll
Merged
[Improvement][UI] Scrolling will be applied to parent model on editor scrolled to top/bottom#11335songjianet merged 1 commit intoapache:devfrom hezean:editor-scroll
songjianet merged 1 commit intoapache:devfrom
hezean:editor-scroll
Conversation
… scrolled to top/bottom
Codecov Report
@@ Coverage Diff @@
## dev #11335 +/- ##
=========================================
Coverage 40.26% 40.26%
Complexity 4843 4843
=========================================
Files 974 974
Lines 37323 37323
Branches 4142 4142
=========================================
Hits 15028 15028
Misses 20749 20749
Partials 1546 1546 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fixes #11328 (Formally the parent model couldn't be scrolled if the mouse is positioned in the editor)
Verify this pull request
This change added tests and can be verified as follows: