Skip to content

[Refactor][UI] Refactor task group queue using NSpace component.#11341

Merged
Amy0104 merged 2 commits intoapache:devfrom
songjianet:refactor-task-group-queue
Aug 8, 2022
Merged

[Refactor][UI] Refactor task group queue using NSpace component.#11341
Amy0104 merged 2 commits intoapache:devfrom
songjianet:refactor-task-group-queue

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

ref #10844

image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@songjianet songjianet added UI ui and front end related refactor labels Aug 8, 2022
@songjianet songjianet added this to the 3.1.0 milestone Aug 8, 2022
@songjianet songjianet self-assigned this Aug 8, 2022
@songjianet songjianet requested a review from Amy0104 as a code owner August 8, 2022 02:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #11341 (0cece0c) into dev (0fdec2c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11341      +/-   ##
============================================
- Coverage     40.28%   40.25%   -0.04%     
+ Complexity     4846     4843       -3     
============================================
  Files           974      974              
  Lines         37323    37323              
  Branches       4141     4141              
============================================
- Hits          15036    15024      -12     
- Misses        20739    20751      +12     
  Partials       1548     1548              
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.64% <0.00%> (-7.21%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.78%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit cfb5918 into apache:dev Aug 8, 2022
@songjianet songjianet deleted the refactor-task-group-queue branch August 8, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants