Skip to content

[Doc] Add tools/libs to the init database steps#11345

Merged
zhongjiajie merged 10 commits intoapache:devfrom
SbloodyS:fix_11314
Aug 8, 2022
Merged

[Doc] Add tools/libs to the init database steps#11345
zhongjiajie merged 10 commits intoapache:devfrom
SbloodyS:fix_11314

Conversation

@SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Aug 8, 2022

Purpose of the pull request

Fix #11314

@SbloodyS SbloodyS added bug Something isn't working document labels Aug 8, 2022
@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 8, 2022
@SbloodyS SbloodyS self-assigned this Aug 8, 2022
@SbloodyS SbloodyS requested a review from EricGao888 as a code owner August 8, 2022 06:51
EricGao888
EricGao888 previously approved these changes Aug 8, 2022
View reviewed changes
zhongjiajie
zhongjiajie previously approved these changes Aug 8, 2022
View reviewed changes
@zhongjiajie
Copy link
Member

zhongjiajie commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change /development/ to docs/contribute

@SbloodyS SbloodyS dismissed stale reviews from zhongjiajie and EricGao888 via 96c4f8d August 8, 2022 07:13
@EricGao888
Copy link
Member

EricGao888 commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change /development/ to docs/contribute

I think we might have some doc checks in our pre-commit hook #11347 🤔

@SbloodyS
Copy link
Member Author

SbloodyS commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change /development/ to docs/contribute

I think we might have some doc checks in our pre-commit hook #11347 🤔

I haven't used this new feature yet. 🤣 Can we add this to the docs too?

@EricGao888
Copy link
Member

EricGao888 commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change /development/ to docs/contribute

I think we might have some doc checks in our pre-commit hook #11347 🤔

I haven't used this new feature yet. 🤣 Can we add this to the docs too?

We have already had it in our docs. But later this week I will find a way to install the hook automatically for our developers in case they miss it in docs : ) https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/development-environment-setup.md#code-style

@zhongjiajie
Copy link
Member

zhongjiajie commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it is related to the doc migration PR #11313 . You should change /development/ to docs/contribute

I think we might have some doc checks in our pre-commit hook #11347 🤔

It is not related to our CI like github action or pre-hook, this dead link because we separate our docs into multiple repos, but they have to connect to each other. In this case, we have to use the whole URL in our document, but when we change the place of source docs(PR1), the link will be changed, and a dead link error throw.
The reason why we can pass CI in PR1 is that before the PR1 merged, the whole URL link still work, but it become deadlink when PR1 is be merged

@EricGao888
Copy link
Member

EricGao888 commented Aug 8, 2022

there is a deadlink found, could you please also fix the dead link in this PR, it is related to the doc migration PR #11313 . You should change /development/ to docs/contribute

I think we might have some doc checks in our pre-commit hook #11347 🤔

It is not related to our CI like github action or pre-hook, this dead link because we separate our docs into multiple repos, but they have to connect to each other. In this case, we have to use the whole URL in our document, but when we change the place of source docs(PR1), the link will be changed, and a dead link error throw. The reason why we can pass CI in PR1 is that before the PR1 merged, the whole URL link still work, but it become deadlink when PR1 is be merged

Got it, thx @zhongjiajie for the explanations!

zhongjiajie
zhongjiajie reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 21 Bugs
Vulnerability E 9 Vulnerabilities
Security Hotspot E 37 Security Hotspots
Code Smell A 2099 Code Smells

37.9% 37.9% Coverage
2.4% 2.4% Duplication

@zhongjiajie zhongjiajie changed the title [Fix-11314] [Doc] add tools/libs to the init database steps [Doc] Add tools/libs to the init database steps Aug 8, 2022
@zhongjiajie zhongjiajie merged commit 983f9b4 into apache:dev Aug 8, 2022
@SbloodyS SbloodyS deleted the fix_11314 branch August 9, 2022 01:36
zhongjiajie pushed a commit that referenced this pull request Aug 9, 2022
@SbloodyS @zhongjiajie
[Doc] Add tools/libs to the init database steps (#11345)
92ca3df 
(cherry picked from commit 983f9b4)
yushxzh pushed a commit to iclass/dolphinscheduler that referenced this pull request Aug 17, 2022
Merge branch '3.0.0-release' into 3.0.0-release-tianyin
df7aff8 
* 3.0.0-release: (161 commits)
  impv: Versioning python document
  [doc] Remove not exists task for version 3.0.0
  [doc] Correct check style path
  [doc] Fix checkstyle path
  [Doc] Add tools/libs to the init database steps (apache#11345)
  [doc] Fixed hadoop link to avoid dead link
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release 3.0.0
  Correct docdev.js version
  [doc] migrate community and development docs into main repo (apache#11313)
  Fix TaskGroup cannot work and will cause master dead loop (apache#11254) (apache#11318)
  Some docs version change
  fix: cherry pick bug for document img path
  [Doc] update the configuration doc (apache#11113)
  [doc] Add notice when environment can not select (apache#11276)
  fix: Current node settings number of failed retries may not be negative (apache#10530)
  [Fix]Recovery Traffic Control Config (apache#10505)
  Modify obsolete swagger parameters in AuditLogController (apache#10494)
  [fix][master]: fix condition npe (apache#10478)
  Update SparkRuntimeEnvironment.java (apache#10549)
  ...

# Conflicts:
#	deploy/kubernetes/dolphinscheduler/values.yaml
#	dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TenantService.java
#	dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java
#	dolphinscheduler-api/src/main/resources/application.yaml
#	dolphinscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/StandaloneServer.java
#	dolphinscheduler-standalone-server/src/main/resources/application.yaml
#	dolphinscheduler-ui/src/views/home/index.tsx
@zhongjiajie zhongjiajie modified the milestones: 3.0.1, 3.0.0 Sep 17, 2022
@zhongjiajie zhongjiajie added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 17, 2022
@yzeng25 yzeng25 mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@EricGao888 EricGao888 EricGao888 approved these changes

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

Assignees

@SbloodyS SbloodyS

Labels

bug Something isn't working document Pyscheduler release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

[Doc][pseudo cluster] Missing guide of add mysql jars to tools libs path

3 participants

@SbloodyS @zhongjiajie @EricGao888