Skip to content

[FIXED-10392]: SQL Task Node Custom Parameters run failed#11359

Closed
liu-lewis wants to merge 2 commits intoapache:devfrom
liu-lewis:ganlin-patch-10392
Closed

[FIXED-10392]: SQL Task Node Custom Parameters run failed#11359
liu-lewis wants to merge 2 commits intoapache:devfrom
liu-lewis:ganlin-patch-10392

Conversation

@liu-lewis
Copy link

@liu-lewis liu-lewis commented Aug 8, 2022

Purpose of the pull request

fix #10392

Brief change log

modify: org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor#setSqlParamsMap return format SQL
add SqlTask test: org.apache.dolphinscheduler.plugin.task.sql.SqlTaskTest

Verify this pull request

@SbloodyS
Copy link
Member

SbloodyS commented Aug 9, 2022

Hi @liu-lewis , please associate the issue.

@liu-lewis
Copy link
Author

Hi @liu-lewis , please associate the issue.

Ok, this is my first PR, i'm tring to do this better

@liu-lewis liu-lewis changed the title Ganlin patch 10392 [FIXED-10392]: SQL Task Node Custom Parameters run failed Aug 16, 2022
@liu-lewis
Copy link
Author

liu-lewis commented Aug 16, 2022

Hi @liu-lewis , please associate the issue.

Hi @SbloodyS , this issue has closed by PR #11285 ,and this is my first PR, could you help me to check what improvements can I make for this PR so that I can submit it correctly next time.

@SbloodyS
Copy link
Member

Please take a look when you have spare time. @zhuangchong

@@ -0,0 +1,108 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a common.properties here?

@davidzollo
Copy link
Contributor

Hi @liu-lewis , please associate the issue.

Hi @SbloodyS , this issue has closed by PR #11285 ,and this is my first PR, could you help me to check what improvements can I make for this PR so that I can submit it correctly next time.

thanks for your first contribution, does this mean that you solve the same issue with PR #11285?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 29, 2023
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [SQL] SQL Task Node Custom Parameters run failed

5 participants