[FIXED-10392]: SQL Task Node Custom Parameters run failed#11359
[FIXED-10392]: SQL Task Node Custom Parameters run failed#11359liu-lewis wants to merge 2 commits intoapache:devfrom
Conversation
|
Hi @liu-lewis , please associate the issue. |
Ok, this is my first PR, i'm tring to do this better |
Hi @SbloodyS , this issue has closed by PR #11285 ,and this is my first PR, could you help me to check what improvements can I make for this PR so that I can submit it correctly next time. |
|
Please take a look when you have spare time. @zhuangchong |
| @@ -0,0 +1,108 @@ | |||
| # | |||
There was a problem hiding this comment.
Why create a common.properties here?
thanks for your first contribution, does this mean that you solve the same issue with PR #11285? |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
Purpose of the pull request
fix #10392
Brief change log
modify: org.apache.dolphinscheduler.plugin.task.api.AbstractTaskExecutor#setSqlParamsMap return format SQL
add SqlTask test: org.apache.dolphinscheduler.plugin.task.sql.SqlTaskTest
Verify this pull request