[test-11432][HttpTask] Add unit tests to http task#11453
Merged
davidzollo merged 5 commits intoapache:devfrom Aug 17, 2022
Merged
[test-11432][HttpTask] Add unit tests to http task#11453davidzollo merged 5 commits intoapache:devfrom
davidzollo merged 5 commits intoapache:devfrom
Conversation
fangyinc
requested review from
SbloodyS,
caishunfeng,
kezhenxu94 and
zhuangchong
as code owners
EricGao888
reviewed
Aug 12, 2022
...duler-task-http/src/test/java/org/apache/dolphinscheduler/plugin/task/http/HttpTaskTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #11453 +/- ##
============================================
+ Coverage 39.36% 39.63% +0.26%
- Complexity 4633 4671 +38
============================================
Files 987 987
Lines 37571 37571
Branches 4186 4187 +1
============================================
+ Hits 14790 14890 +100
+ Misses 21229 21119 -110
- Partials 1552 1562 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
caishunfeng
reviewed
Aug 13, 2022
...duler-task-http/src/test/java/org/apache/dolphinscheduler/plugin/task/http/HttpTaskTest.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Contributor
Author
|
@EricGao888 @SbloodyS Can someone review the code, if there is any problem I will fix it~ |
zhuxt2015
pushed a commit
to zhuxt2015/dolphinscheduler
that referenced
this pull request
Aug 21, 2022
* [test][HttpTask] Add unit tests to http task * [test][HttpTask] fix http task test code format problem * [test][HttpTask] fix http task test code replace http code to constants
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
* [test][HttpTask] Add unit tests to http task * [test][HttpTask] fix http task test code format problem * [test][HttpTask] fix http task test code replace http code to constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #11432
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md