Skip to content

[Refactor][UI] Refactor task definition batch stream using NSpace component.#11485

Merged
songjianet merged 3 commits intoapache:devfrom
songjianet:refactor-task-definition
Aug 15, 2022
Merged

[Refactor][UI] Refactor task definition batch stream using NSpace component.#11485
songjianet merged 3 commits intoapache:devfrom
songjianet:refactor-task-definition

Conversation

@songjianet
Copy link
Member

Purpose of the pull request

ref #10844

image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@songjianet songjianet added UI ui and front end related refactor labels Aug 15, 2022
@songjianet songjianet added this to the 3.1.0 milestone Aug 15, 2022
@songjianet songjianet self-assigned this Aug 15, 2022
@songjianet songjianet requested a review from Amy0104 as a code owner August 15, 2022 09:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #11485 (085aab1) into dev (a4bdadb) will not change coverage.
The diff coverage is n/a.

❗ Current head 085aab1 differs from pull request most recent head 3870559. Consider uploading reports for the commit 3870559 to get more accurate results

@@            Coverage Diff            @@
##                dev   #11485   +/-   ##
=========================================
  Coverage     39.36%   39.36%           
- Complexity     4630     4632    +2     
=========================================
  Files           987      987           
  Lines         37566    37566           
  Branches       4184     4183    -1     
=========================================
  Hits          14789    14789           
  Misses        21226    21226           
  Partials       1551     1551           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 4d06319 into apache:dev Aug 15, 2022
@songjianet songjianet deleted the refactor-task-definition branch August 15, 2022 13:17
zhuxt2015 pushed a commit to zhuxt2015/dolphinscheduler that referenced this pull request Aug 21, 2022
…ponent. (apache#11485)

* [Refactor][UI] Refactor task definition batch stream using NSpace component.

* [Refactor][UI] Refactor task definition batch stream using NSpace component.

* [Refactor][UI] Refactor task definition batch stream using NSpace component.
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
…ponent. (apache#11485)

* [Refactor][UI] Refactor task definition batch stream using NSpace component.

* [Refactor][UI] Refactor task definition batch stream using NSpace component.

* [Refactor][UI] Refactor task definition batch stream using NSpace component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants