[Improvement-11507][Workflow] support sort for workfow definition list #11509
Closed
106umao wants to merge 3 commits intoapache:devfrom
106umao:workflow-sort
Closed
[Improvement-11507][Workflow] support sort for workfow definition list #11509106umao wants to merge 3 commits intoapache:devfrom 106umao:workflow-sort
106umao wants to merge 3 commits intoapache:devfrom
106umao:workflow-sort
Conversation
106umao
requested review from
SbloodyS,
caishunfeng and
kezhenxu94
as code owners
106umao
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #11509 +/- ##
============================================
- Coverage 39.36% 39.35% -0.01%
- Complexity 4630 4631 +1
============================================
Files 987 988 +1
Lines 37566 37579 +13
Branches 4184 4185 +1
============================================
+ Hits 14789 14791 +2
- Misses 21226 21236 +10
- Partials 1551 1552 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
lenboo
reviewed
Aug 17, 2022
|
|
||
| package org.apache.dolphinscheduler.api.enums; | ||
|
|
||
| public enum SortEnum { |
lenboo
reviewed
Aug 17, 2022
| @RequestParam(value = "searchVal", required = false) String searchVal, | ||
| @RequestParam(value = "otherParamsJson", required = false) String otherParamsJson, | ||
| @RequestParam(value = "userId", required = false, defaultValue = "0") Integer userId, | ||
| @RequestParam(value = "sortEnum", required = false) SortEnum sortType, |
lenboo
reviewed
Aug 17, 2022
| <appender-ref ref="STDOUT"/> | ||
| </then> | ||
| </if> | ||
| <appender-ref ref="STDOUT"/> |
Contributor
Author
|
close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #11507
Purpose of the pull request
Brief change log
close #11507
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md