[improvement] Add two parameters in workergroup, and support the application of description display and other parameters#11542
Merged
lenboo merged 16 commits intoapache:devfrom Aug 23, 2022
Conversation
Zephyrcf
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
ruanwenjun
reviewed
Aug 18, 2022
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/WorkerGroup.java
Outdated
Show resolved
Hide resolved
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
lenboo
reviewed
Aug 18, 2022
...uler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkerGroupController.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #11542 +/- ##
============================================
+ Coverage 39.79% 39.80% +0.01%
- Complexity 4696 4697 +1
============================================
Files 993 992 -1
Lines 37662 37655 -7
Branches 4187 4188 +1
============================================
+ Hits 14987 14990 +3
+ Misses 21109 21099 -10
Partials 1566 1566
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanwenjun
requested changes
Aug 20, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
ruanwenjun
requested changes
Aug 20, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
Zephyrcf
requested review from
lenboo
and removed request for
SbloodyS,
caishunfeng and
zhongjiajie
lenboo
reviewed
Aug 22, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
lenboo
reviewed
Aug 22, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
lenboo
reviewed
Aug 22, 2022
...r-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java
Outdated
Show resolved
Hide resolved
lenboo
reviewed
Aug 22, 2022
...ster/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
Aug 22, 2022
...ster/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java
Outdated
Show resolved
Hide resolved
Zephyrcf
changed the title
Zephyrcf
changed the title
|
SonarCloud Quality Gate failed. |
wangfann
pushed a commit
to wangfann/dolphinscheduler
that referenced
this pull request
Aug 23, 2022
…ication of description display and other parameters (apache#11542) * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [improvement] The default worker grouping supports editing * [improvement] The default worker grouping supports editing * Update WorkerGroupServiceImpl.java * Update WorkerGroupServiceImpl.java * The default worker grouping supports editing * update sql file * update * update * update * update
3 tasks
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…ication of description display and other parameters (apache#11542) * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [Improvement] Improvement default worker group * [improvement] The default worker grouping supports editing * [improvement] The default worker grouping supports editing * Update WorkerGroupServiceImpl.java * Update WorkerGroupServiceImpl.java * The default worker grouping supports editing * update sql file * update * update * update * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #11546
Brief change log
Support the default worker group for editing, and add all worker group description functions.