[Improvement]Add a stop function when you are ready to do pause operation#11543
Merged
lenboo merged 2 commits intoapache:devfrom Aug 18, 2022
106umao:feat/ready-pause-stop
Merged
[Improvement]Add a stop function when you are ready to do pause operation#11543lenboo merged 2 commits intoapache:devfrom 106umao:feat/ready-pause-stop
lenboo merged 2 commits intoapache:devfrom
106umao:feat/ready-pause-stop
Conversation
Contributor
|
no issue and no comments about this pr |
106umao
changed the title
106umao
changed the title
WangJPLeo
reviewed
Aug 18, 2022
| case PAUSE: | ||
| case STOP: | ||
| if (executionStatus.isRunning()) { | ||
| if (executionStatus.canStop()) { |
Contributor
There was a problem hiding this comment.
PAUSE status check not same as STOP.
lenboo
approved these changes
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## dev #11543 +/- ##
============================================
- Coverage 39.67% 39.66% -0.01%
+ Complexity 4697 4695 -2
============================================
Files 993 993
Lines 37692 37695 +3
Branches 4197 4198 +1
============================================
- Hits 14953 14951 -2
- Misses 21170 21173 +3
- Partials 1569 1571 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
zhuxt2015
pushed a commit
to zhuxt2015/dolphinscheduler
that referenced
this pull request
Aug 21, 2022
…tion (apache#11543) * add can stop for execute state machine * add execute type check for pause operation
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…tion (apache#11543) * add can stop for execute state machine * add execute type check for pause operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
this pr will close #11547
Brief change log
When a workflow is running or blocking for a long time, the user may do pause opteration, and the pause operation may be blocked while waiting for the task to execute, so I think there should be an option to stop it when it is ready pause status
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md