[fix-#11689] change replaceAll to replace in method of tryExecuteSqlResolveColumnNames#11696
Merged
ruanwenjun merged 1 commit intoapache:devfrom Sep 5, 2022
Merged
Conversation
…xecuteSqlResolveColumnNames
fuchanghai
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
fuchanghai
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #11696 +/- ##
============================================
- Coverage 39.81% 39.80% -0.01%
+ Complexity 4720 4717 -3
============================================
Files 1002 1002
Lines 37872 37872
Branches 4229 4230 +1
============================================
- Hits 15077 15075 -2
- Misses 21194 21195 +1
- Partials 1601 1602 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
ruanwenjun
changed the title
ruanwenjun
requested changes
Sep 5, 2022
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Could you please add UT for this, in fact, replace is the same as replaceAll, will replace all matched.
ruanwenjun
approved these changes
Sep 5, 2022
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Sorry, I missunstanderstand, this bug is caused by we didn't translate .
Member
Author
you can see the issue #11689 |
Member
Author
thanks for your review |
fengjian1129
pushed a commit
to fengjian1129/dolphinscheduler
that referenced
this pull request
Sep 13, 2022
…xecuteSqlResolveColumnNames (apache#11696)
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Sep 17, 2022
… method of tryExecuteSqlResolveColumnNames apache#11696
caishunfeng
added a commit
that referenced
this pull request
Sep 17, 2022
* [Cherry-pick-3.0.1][fix-#11691] Add lz4-java in clickhouse datasource. #11697 * [Cherry-pick-3.0.1][fix-#11689] change replaceAll to replace in method of tryExecuteSqlResolveColumnNames #11696 * [fix-11378] fix API-Server release response message typo (#11400) * [fix-11295] remove duplicate classes * [fix-11378] fix response message error Co-authored-by: fuchanghai <changhai.fu@marketingforce.com> Co-authored-by: fuchanghai <33984497+fuchanghai@users.noreply.github.com> Co-authored-by: fuchanghai <changhai.fu@marketingforce.com>
caishunfeng
added
the
release cherry-pick
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…xecuteSqlResolveColumnNames (apache#11696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…SqlResolveColumnNames
Purpose of the pull request
Brief change log
change replaceAll to replace in method of tryExecuteSqlResolveColumnNames
Verify this pull request
This pull request is code cleanup without any test coverage.
this close #11689