Skip to content

[fix][dao]fix mapper table name to t_ds_fav_task#11756

Closed
Tianqi-Dotes wants to merge 1 commit intoapache:devfrom
Tianqi-Dotes:fix/mapper
Closed

[fix][dao]fix mapper table name to t_ds_fav_task#11756
Tianqi-Dotes wants to merge 1 commit intoapache:devfrom
Tianqi-Dotes:fix/mapper

Conversation

@Tianqi-Dotes
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Tianqi-Dotes Tianqi-Dotes added the bug Something isn't working label Sep 2, 2022
@Tianqi-Dotes Tianqi-Dotes self-assigned this Sep 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #11756 (3d88ff9) into dev (277f137) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11756      +/-   ##
============================================
- Coverage     39.64%   39.60%   -0.04%     
+ Complexity     4694     4692       -2     
============================================
  Files          1013     1013              
  Lines         37928    37928              
  Branches       4241     4241              
============================================
- Hits          15038    15023      -15     
- Misses        21281    21299      +18     
+ Partials       1609     1606       -3     
Impacted Files Coverage Δ
...eduler/server/worker/task/WorkerHeartBeatTask.java 68.08% <0.00%> (-8.52%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhuangchong
Copy link
Contributor

I checked that this part of the dev branch has been modified, I will close this PR first, if there is a problem, you can reopen it.

<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd" >
<mapper namespace="org.apache.dolphinscheduler.dao.mapper.FavTaskMapper">
<select id="getUserFavTaskTypes" resultType="string">
select task_name
from t_ds_fav_task
where user_id = #{userId}
</select>
<delete id="deleteUserFavTask">
delete
from t_ds_fav_task
where user_id = #{userId}
and task_name = #{taskName}
</delete>

@zhuangchong zhuangchong closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants